https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 83715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83715&action=edit Bug 22083: Typo in circulation_batch_checkouts.tt There is a typo in circulation_batch_checkouts.tt that makes Koha skip a warning if the user cannot borrow due to circulation rules. This patch corrects this typo. To test: 1. In Administration > Global system preferences, 'Allow' BatchCheckouts and enter patron categories in BatchCheckoutsValidCategories 2. Go to Administration > Circulation and fines rules 3. Enter a rule where a certain category of patrons (that is in BatchCheckoutsValidCategories) cannot take out a particular item type 4. Search the catalog for an item of that item type 5. Copy the barcode 6. Go into patrons and find a patron of that category 7. Click on the Batch checkout tab 8. Paste the barcode in the box and click Check out 9. It should say 'Too many checked out' 10. Apply the patch 11. Try the check out again, it should show both warnings ('Too many checked out' and 'This patron can't check out this item per library circulation policy') -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also think that the 'too many checked out' warning should only appear if the circulation rules allow 1 or more. If the circulation rules allow 0, only 'This patron can't check out this item per library circulation rules' should show... It is, however, outside of the scope of this bug and outside my capabilities... Just throwing it out there if someone wants to take it over :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83715|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83763&action=edit Bug 22083: Typo in circulation_batch_checkouts.tt There is a typo in circulation_batch_checkouts.tt that makes Koha skip a warning if the user cannot borrow due to circulation rules. This patch corrects this typo. To test: 1. In Administration > Global system preferences, 'Allow' BatchCheckouts and enter patron categories in BatchCheckoutsValidCategories 2. Go to Administration > Circulation and fines rules 3. Enter a rule where a certain category of patrons (that is in BatchCheckoutsValidCategories) cannot take out a particular item type 4. Search the catalog for an item of that item type 5. Copy the barcode 6. Go into patrons and find a patron of that category 7. Click on the Batch checkout tab 8. Paste the barcode in the box and click Check out 9. It should say 'Too many checked out' 10. Apply the patch 11. Try the check out again, it should show both warnings ('Too many checked out' and 'This patron can't check out this item per library circulation policy') Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83763|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83842&action=edit Bug 22083: Typo in circulation_batch_checkouts.tt There is a typo in circulation_batch_checkouts.tt that makes Koha skip a warning if the user cannot borrow due to circulation rules. This patch corrects this typo. To test: 1. In Administration > Global system preferences, 'Allow' BatchCheckouts and enter patron categories in BatchCheckoutsValidCategories 2. Go to Administration > Circulation and fines rules 3. Enter a rule where a certain category of patrons (that is in BatchCheckoutsValidCategories) cannot take out a particular item type 4. Search the catalog for an item of that item type 5. Copy the barcode 6. Go into patrons and find a patron of that category 7. Click on the Batch checkout tab 8. Paste the barcode in the box and click Check out 9. It should say 'Too many checked out' 10. Apply the patch 11. Try the check out again, it should show both warnings ('Too many checked out' and 'This patron can't check out this item per library circulation policy') Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22083 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.