[Bug 20081] New: Enable uploaded pdfs to be viewed inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Bug ID: 20081 Summary: Enable uploaded pdfs to be viewed inline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When attaching files to bib records using the upload.pl plugin it would be nice to display viewable files in the browser instead of forcing download. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70864&action=edit Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14282 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70864|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70878&action=edit Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The idea on 14282 was to do this somewhat less hardcoded and more configurable.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Hi Marcel, I saw that bug but wasn't sure what you envisioned, what would you suggest? My first thought was a syspref specifying the extensions that should be inline. -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Arturo <library@sll.texas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library@sll.texas.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70878|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73257&action=edit Bug 20081: Set inline headers for uploaded pdfs To test: 1 - Edit a framework and add the 'upload/pl' plugin to the 856 field 2 - Attach a pdf to one record 3 - Attach a different type of file to another (To attach, edit a record in the framework edited above and find the helper by the 856 field) 4 - Click the links on the record 5 - Verify the pdf opens inline 6 - Verify the other file does not 7 - prove t/db_dependent/Upload.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org