[Bug 22621] New: Filters on subscription result list search the wrong column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Bug ID: 22621 Summary: Filters on subscription result list search the wrong column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- Created attachment 87315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87315&action=edit Sceenshot 1 - search failed On the serial subscription page result, the filters search the column on its left. Could it be the first column with check box but without filter that create the gap ? See the 2 screenshots attached : - #1 : failed searching "notes" using the filter on "Notes" column - #2 : 1 result (as expected) searching "notes" using the filter on "Library" column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 87316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87316&action=edit Sceenshot 1 - search succeed using the fliter of the column on the right -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 88585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88585&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |18426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 [Bug 18426] Subscriptions batch editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88585|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 88730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88730&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88730|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88773&action=edit Bug 22621: Fix filters on subscription search results Caused by commit 4e698f7b478a094d7b32ebfeaa917bca05ebcc5b Bug 18426: Allow to edit subscriptions in batch There is a shift caused by a hidden column, which make the filters searching on the previous column. Test plan: - Add 1+ searchable additional field for subscription - Create a new subscription - Search for subscriptions - Use the column filters to filter the results => The results must be filtered accordingly Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22621 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org