[Bug 23991] New: Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug ID: 23991 Summary: Move SearchSuggestion to Koha::Suggestions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95172&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The hardest part is missing, suggestion/suggestion.pl I will come back to this one later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug 23991 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95172|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115203&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115207&action=edit Script for making some suggestions for testing For making suggestions in various statuses in several branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Updating suggestions, applying filters all seem to work as expected - the only thing I note is that if I have selected a library on the dropdown above the table and then clear filters on the left I am defaulted back to my logged in library Also, on the homepage the count of pending suggestions does not exclude archived suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Two more things, not necessarily caused by this: 1 - If I add a new suggestion I am returned to the suggestions for that library, but I will be on the first tab (accepted for example), not the pending tab 2 - if I have multiple suggestions in unknown statuses I get multiple tabs when organizing by status, but they only say 'unknown' I can tell what the actual status is - the tabe shoudl include the unknown code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #5)
Updating suggestions, applying filters all seem to work as expected - the only thing I note is that if I have selected a library on the dropdown above the table and then clear filters on the left I am defaulted back to my logged in library
That's the behaviour in master.
Also, on the homepage the count of pending suggestions does not exclude archived suggestions
Same, opened bug 27462. Maybe we should simplify this view and have it using the REST API (and the datatables wrapper). With correct column filtering we shouldn't need the different "organized by" views. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115203|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116639&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is ready for testing :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116639|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 118454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118454&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Conflicts with bug 26406 fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Failed QA --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Suggestions are hidden on the opac side, on the 'cgi-bin/koha/opac-suggestions.pl' page. Checked on master without the patch, they are correctly displayed, as well on the intranet side on '/cgi-bin/koha/members/purchase-suggestions.pl' with the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Attachment #118454|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119256&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Séverine, indeed there were a couple of mistakes in the patch. It should work correctly now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This has been forgotten! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119256|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127058&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patch rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- I get an error when I try to access the suggestions page in the OPAC: Could not compile /kohadevbox/koha/opac/opac-suggestions.pl: "SearchSuggestion" is not exported by the C4::Suggestions module Can't continue after import errors at /kohadevbox/koha/opac/opac-suggestions.pl line 27. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127058|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127100&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Looking. I'm investigating this query log differences: before: 242 Query select DISTINCT(STATUS) as value, count(*) as cnt from suggestions group by value order by STATUS 242 Query SELECT COUNT( * ) FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) 242 Query select DISTINCT(managedby) as value, count(*) as cnt from suggestions group by value order by managedby 242 Query select DISTINCT(acceptedby) as value, count(*) as cnt from suggestions group by value order by acceptedby 242 Query select DISTINCT(suggestedby) as value, count(*) as cnt from suggestions group by value order by suggestedby 242 Query select DISTINCT(budgetid) as value, count(*) as cnt from suggestions group by value order by budgetid after: 242 Query select DISTINCT(STATUS) as value, count(*) as cnt from suggestions group by value order by STATUS 242 Query SELECT COUNT( * ) FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) 242 Query select DISTINCT(managedby) as value, count(*) as cnt from suggestions group by value order by managedby 242 Query select DISTINCT(acceptedby) as value, count(*) as cnt from suggestions group by value order by acceptedby 242 Query select DISTINCT(suggestedby) as value, count(*) as cnt from suggestions group by value order by suggestedby 242 Query select DISTINCT(budgetid) as value, count(*) as cnt from suggestions group by value order by budgetid 242 Query SELECT COUNT( * ) FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) 242 Query SELECT COUNT( * ) FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) 242 Query SELECT `me`.`suggestionid`, `me`.`suggestedby`, `me`.`suggesteddate`, `me`.`managedby`, `me`.`manageddate`, `me`.`acceptedby`, `me`.`accepteddate`, `me`.`rejectedby`, `me`.`rejecteddate`, `me`.`lastmodificationby`, `me`.`lastmodificationdate`, `me`.`STATUS`, `me`.`archived`, `me`.`note`, `me`.`author`, `me`.`title`, `me`.`copyrightdate`, `me`.`publishercode`, `me`.`date`, `me`.`volumedesc`, `me`.`publicationyear`, `me`.`place`, `me`.`isbn`, `me`.`biblionumber`, `me`.`reason`, `me`.`patronreason`, `me`.`budgetid`, `me`.`branchcode`, `me`.`collectiontitle`, `me`.`itemtype`, `me`.`quantity`, `me`.`currency`, `me`.`price`, `me`.`total` FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) 242 Query SELECT `me`.`module`, `me`.`page`, `me`.`tablename`, `me`.`columnname`, `me`.`cannot_be_toggled`, `me`.`is_hidden` FROM `columns_settings` `me` WHERE ( ( `module` = 'acqui' AND `page` = 'suggestions' AND `tablename` = 'suggestions' ) ) 242 Query SELECT COUNT( * ) FROM `suggestions` `me` WHERE ( ( `STATUS` = 'ASKED' AND `archived` = '0' AND `branchcode` = 'CPL' ) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127100|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128071&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Bug 23991: Remove unused variable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128072&action=edit Bug 23991: (follow-up) Fix wrong import Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128073&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128074&action=edit Bug 23991: Add Koha::Suggestions->search_limited POD Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128075&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- bug 23991 - I ran the script to generate random suggesstions - I can see them - apply patch, I don't see them If I load from library link on homepage, I see them but if i change library using pulldown I can't the 'all libraries' link form homepage does not work either http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&budgetid=__ANY__ that shows nothing http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL That shows things Logs show this often: [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 113. [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 115. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 [Bug 29886] Add Koha::Suggestions->search_limited -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128072|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129511&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129512&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129513&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nick, I stripped the Koha::Suggestions->search_limited and moved to 29886. I found issues when writing unit tests for it, and they might be responsible for the problems you found. I have attached a new patchset, which is the same as before, without that. But given the fact I fixed some issues on how ->search_limited worked, it might be good if you could re-test. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129523&action=edit Bug 23991: Fix branchcode and budgetid filtering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #26)
bug 23991 - I ran the script to generate random suggesstions - I can see them - apply patch, I don't see them
If I load from library link on homepage, I see them but if i change library using pulldown I can't
the 'all libraries' link form homepage does not work either
http://localhost:8081/cgi-bin/koha/suggestion/suggestion. pl?branchcode=FFL&displayb[…]eptedby=&accepteddate_from=&accepteddate_to=&bud getid=__ANY__ that shows nothing
http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=FFL That shows things
Logs show this often: [2022/01/14 15:21:34] [WARN] Use of uninitialized value in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 113. [2022/01/14 15:21:34] [WARN] Use of uninitialized value $v in string eq at /kohadevbox/koha/suggestion/suggestion.pl line 115.
Should be fixed with the last patch. There is certainly more to do to clean this controller and template, but prefer to not rewrite them here and focus on the SearchSuggestion move only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This error is suspicious: "my" variable $suggestion masks earlier declaration in same scope there's effectively a variable overwrite at the top level. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure about it, I always privileged iterator over retrieving the whole set. If this is what we really want it needs to be deeply investigated and that we agree on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130049&action=edit Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug... Redoing on top of bug 28941 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #34)
About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure about it, I always privileged iterator over retrieving the whole set. If this is what we really want it needs to be deeply investigated and that we agree on it.
Another option would've been to calculate the count and add a new template param. I decided to minimize the changes to your patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30017 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we get this moving please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131896&action=edit Bug 23991: (follow-up) Missing semicolon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Everything works well, one issue I found: If I add a new suggestion with acquisition library 'Any' I am returned to view for logged in branch, but no suggestions are loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug 23991 depends on bug 29886, which changed state. Bug 29886 Summary: Add Koha::Suggestions->search_limited https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132026&action=edit Bug 23991: Fix 'all' libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #39)
Everything works well, one issue I found: If I add a new suggestion with acquisition library 'Any' I am returned to view for logged in branch, but no suggestions are loaded
I don't recreate that, can you provide more detail please? (In reply to Nick Clemens from comment #39)
Everything works well, one issue I found: If I add a new suggestion with acquisition library 'Any' I am returned to view for logged in branch, but no suggestions are loaded
Thanks! I found another weirdness but it's in master as well. If you have 2 suggestions, branchcodes are 'CPL' and NULL, organize by "library". You will see CPL (1) and Any (2). Will fix on a follow-up bug report if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129511|0 |1 is obsolete| | Attachment #129512|0 |1 is obsolete| | Attachment #129513|0 |1 is obsolete| | Attachment #129523|0 |1 is obsolete| | Attachment #130049|0 |1 is obsolete| | Attachment #131896|0 |1 is obsolete| | Attachment #132026|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132169&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132170&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132171&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132172&action=edit Bug 23991: Fix branchcode and budgetid filtering Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132173&action=edit Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug... Redoing on top of bug 28941 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132174&action=edit Bug 23991: (follow-up) Missing semicolon Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132175&action=edit Bug 23991: Fix 'all' libraries Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #41)
I found another weirdness but it's in master as well. If you have 2 suggestions, branchcodes are 'CPL' and NULL, organize by "library". You will see CPL (1) and Any (2).
Will fix on a follow-up bug report if it's needed.
Yeah, 'Any' looks like 'All libraries' - we could add a new tab for 'Any' - but another report indeed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I already tested this one. Will do a second round to check the rebase fixes and Nick's follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #49)
(In reply to Jonathan Druart from comment #41)
I found another weirdness but it's in master as well. If you have 2 suggestions, branchcodes are 'CPL' and NULL, organize by "library". You will see CPL (1) and Any (2).
Will fix on a follow-up bug report if it's needed.
Yeah, 'Any' looks like 'All libraries' - we could add a new tab for 'Any' - but another report indeed
I believe it was supposed to work that way... but I don't remember why anymore :) So possibly a rename would do? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have 2 suggestions for Centerville, both are Pending and archived. On master, I can make them display by choosing "Include archived" and starting the search: http://localhost:8081/cgi-bin/koha/suggestion/suggestion.pl?branchcode=CPL&displayby=branchcode&title=&author=&isbn=&publishercode=©rightdate=&collectiontitle=&filter_archived=on&STATUS=&suggestedby=&suggesteddate_from=&suggesteddate_to=&managedby=&manageddate_from=&manageddate_to=&acceptedby=&accepteddate_from=&accepteddate_to=&budgetid=__ANY__ This doesn't work with the patch set applied. I can't get archived suggestions to display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133874&action=edit Bug 23991: (follow-up) Add value to filter_archived -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132169|0 |1 is obsolete| | Attachment #132170|0 |1 is obsolete| | Attachment #132171|0 |1 is obsolete| | Attachment #132172|0 |1 is obsolete| | Attachment #132173|0 |1 is obsolete| | Attachment #132174|0 |1 is obsolete| | Attachment #132175|0 |1 is obsolete| | Attachment #133874|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134922&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix branchcode and budgetid filtering Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug... Redoing on top of bug 28941 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (follow-up) Missing semicolon Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix 'all' libraries Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (follow-up) Add value to filter_archived -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I had to squash the patches, sorry for the authorship. This one is becoming painful to rebase... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134922|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136441&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::SearchSuggestion subroutine is badly written and can be replaced by calls to Koha::Suggestions->search. The hard part in this patch is suggestion.pl, the other occurrences have been replaced easily. Test plan: The idea is to test the whole suggestion workflow. 1. Create a suggestion on OPAC 2. Create a suggestion on the staff interface 3. Edit suggestions 4. Filter suggestions (use the different filters and "organize by" values) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-related pages rely on array size instead of querying the DB each time they need to. In the case of suggestion/suggestion.pl it goes from 4 COUNT(*) to 1. To test, with KTD: 1. Run on the host machine: $ docker exec -ti koha_db_1 bash $ mysql -ppassword > SET GLOBAL general_log_file='/var/log/mysql/mycustom.log'; > SET GLOBAL log_output = 'FILE'; > SET GLOBAL general_log = 'ON'; > \q $ tail -f /var/log/mysql/mycustom.log | grep suggestions 2. Visit the different pages changed on this bug => SUCCESS: Some queries 3. Apply this patch 4. Repeat 2 => SUCCESS: Less queries! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix branchcode and budgetid filtering Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug... Redoing on top of bug 28941 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (follow-up) Missing semicolon Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: Fix 'all' libraries Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 23991: (follow-up) Add value to filter_archived Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136442&action=edit Bug 23991: (QA follow-up) Fix tabbing It looks like during one of the many rebases we lost some of the tabn handling, likely due to the conversion from jquery-ui to bootstrap tabs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Everything working as far as I can tell... Code is looking good and with my minor follow-up fixing a rebase issue somewhere along the line I think we're good to go. Passing QA. PS.. I would love to see a switch to API driven tables etc here as suggested earlier in the bug.. the UX is a bit wierd. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31024 [Bug 31024] Switch to the REST Datatables for Suggestion Management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137201&action=edit Bug 23991: Don't display empty div if no suggestions exist If no suggestions exist we should not display an empty tab div -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED Keywords|additional_work_needed | --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31158 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31158 [Bug 31158] Can't filter suggestions by date ranges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #62 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, if needed please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't backport until the depending bug 31158 has been resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This change shouldn't be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31347 [Bug 31347] Suggestion list date filters broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32531 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32531 [Bug 32531] In suggestions, restore Include archived -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33002 [Bug 33002] 'Archive selected' button missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33066 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35911 [Bug 35911] Archived suggestions show in patron's account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35916 [Bug 35916] Purchase suggestions bibliographic filter should be a "contains" search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34963 [Bug 34963] Unable to delete fields in suggestions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org