https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lisetteslatah@gmail.com CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If you look at the examples on the main bug I think we should maybe also remove "Download" and just have "Starter CSV file" or "Sample CSV file" in the link text. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #6 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 112478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112478&action=edit Followup patch to further improve link text for downloading the CSV file on the patron import page. Bug 26724: Improve link text for downloading the CSV file on the patron import page. On tools > Patron import there is a link labeled "here' on the right hand side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Select "Import Patrons" 3. On the right side of the screen observe the "here" link in the text. 4. Apply patch. 5. Refresh page 6. Observe the updated link -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind <david@davidnind.com> --- The patch no longer applies 8-( root@kohadevbox:koha(master)$ git bz apply 26724 Bug 26724 - Improve link text for downloading the CSV file on patron import page 112479 - Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug: 26724: Improve link text for downloading the CSV file on patron import page. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt). error: could not build fake ancestor Patch failed at 0001 Bug: 26724: Improve link text for downloading the CSV file on patron import page. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Attachment-to-Bug-26724---Improve-link-text-for-do-JLSMdI.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112479|0 |1 is obsolete| | --- Comment #9 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 112582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112582&action=edit Attachment to Bug 26724 - Improve link text for downloading the CSV file on patron import page Bug: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 112586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112586&action=edit Bug: Improve link text for downloading the CSV file on patron import page. On tools > Patron Import there is a a link labelled "here" on the right side that should be more descriptive. This patch updates the link. To test: 1. Go to tools 2. Under patrons select "Import Patrons" 3. On the right side of the screen, observe the "here" link in the second list item. 4. Apply patch. 5. Reload page 6. Observe the updated link text. 7. Sign off https://bugs.koha-community.org/show_bug.cgi?id=26724 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Attachment #112586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |the "here" link for the | |example CSV file for | |importing patrons (Tools > | |Patrons and circulation > | |Import patrons). It now | |reads "Download a Starter | |CSV file with all the | |columns. ...", with | |"Starter CSV file" now | |linked. -- You are receiving this mail because: You are watching all bug changes.