[Bug 34656] New: CartToShelf should not trigger RealTimeHoldsQueue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Bug ID: 34656 Summary: CartToShelf should not trigger RealTimeHoldsQueue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The routine only changes the location of the item, this does not affect holdability and does not need to update the queue. This is causing issues when the cron is adding background jobs and is followed by the holds queue builder and the two processes can end up running the queue for a bib at the same time and causing clashes in the tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154957&action=edit Bug 34656: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154958&action=edit Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154957|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 155011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155011&action=edit Bug 34656: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154958|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 155012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155012&action=edit Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 155013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155013&action=edit Bug 34656: (QA follow-up) perltidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Testing notes: For step 3, you need to check out and then check in the item in order to generate RTHQ updates - an update won't trigger on check-in if the item wasn't checked out in the first place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Also - if the holds queue background jobs generated by CartToShelf can cause issues by clashing with the holds queue builder, wouldn't *anything* that causes a real-time holds queue update potentially cause the same issue? I agree with eliminating unnecessary background jobs for its own sake, but there seems to be a bigger bug lurking underneath. (creating a new bug report for it) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34678 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155011|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155207&action=edit Bug 34656: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155012|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155208&action=edit Bug 34656: Do not update real Time Holds Queue when moving from cart to shelf To test: 1 - Enable RealTimeHoldsQueue system preference 2 - Set UpdateItemLocationOnCheckin to _ALL_: CART 3 - Check in an item 4 - Check the background jobs - the RTHQ is updated 5 - perl -e 'use C4::Items; C4::Items::CartToShelf(##);' -- substitute the itemnumber from above 6 - Check the background jobs - no new update to RTHQ 7 - Confirm item was set back to correct permanent_location Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155013|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155209&action=edit Bug 34656: (QA follow-up) perltidy Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I don't get enough the functional side to fully validate this, at least I can tell that the test code looks good and add a 2nd signoff so maybe Emily can pass QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Patch complexity|--- |Small patch Status|Signed Off |Passed QA --- Comment #12 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Thanks, Victor! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.11 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34656 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org