[Bug 5489] New: Send hold email to branch email address if it exists instead of koha email address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Summary: Send hold email to branch email address if it exists instead of koha email address Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Hold requests AssignedTo: kyle.m.hall@gmail.com ReportedBy: amit.gupta@osslabs.biz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Send hold email to branch email address if it exists instead of koha email address -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-14 08:24:12 UTC --- Patch has been sent to the mailing list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2010-12-17 20:01:01 UTC --- Created attachment 2880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2880 signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-19 21:24:16 UTC --- This will need to be documented prominently in the release notes and manual, since this will change the behaviour and people may suddenly have holds going to an email address they don't know to check for them. I wonder if we need this to be a systempreference, so that the behaviour doesn't change on people without them needing to make a conscious decision to change it Pushed to new/enh/bug_5489 ... but not merged until we decide the above question, I certainly lean to not changing current behaviour with no warning (i mean who really reads the release notes :)) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2010-12-19 21:45:12 UTC --- If it's a sys pref then it needs to be a sys pref for all notices (hopefully not a pref for each notice - unless we create a whole new tab) because most libraries assume that the branch email is the one used as the from address on notices and as the email that notices go to at the library - otherwise all branches would have to have access to one email account (the admin email). I agree we need to warn people, but I also think it's the way we all assumed things were working in the first place. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-20 08:36:31 UTC --- If you can think up a way to make it so that people will know that the emails will being sent to and from a different email address. (This patch changes both the from and to address of the emails .. was that the intent?). Then I could be persuaded away from a syspref. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2010-12-20 12:43:06 UTC --- I don't really have an answer for you except updating documentation. But if we add a preference for what email to use for notices, it needs to be one preference for ALL notices - or a preference for each type of notice - it can't be a preference just for this notice. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2010-12-20 13:26:11 UTC ---
If you can think up a way to make it so that people will know that the emails will being sent to and from a different email address...
I wonder if we need some kind of system (similar to or part of the updatedatabase prompt) which alerts the user to changes like this? That way we could include messages like "Warning, as part of this update the following changes will be made..." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |amit.gupta@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-21 08:40:48 UTC --- Thats a good idea Owen, we could do a <b>WARNING: This will change the behaviour of the hold notices, ....</b> in the updatedatabase, that might suffice for this. Coupled with documentation of course. I'll try that out, and if it looks good, ill push up a patch for it and merge it into master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-21 08:43:01 UTC --- Except of course we arent doing a database update :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-21 08:45:45 UTC --- Ok, well im merging it and pushing it, and we have until april to think up a good way to make sure people take note :) (for the 3.4.0 release). Merged to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 --- Comment #11 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-10 10:49:04 UTC --- This bug is mentioned in: Bug 5489: Send hold email to branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013412.... Bug 5489: Send hold email to branch email address if it exists instead of koha email address http://lists.koha-community.org/pipermail/koha-patches/2010-December/013413.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5489 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org