[Bug 14465] New: Broken umlauts/diacritics in feedback of last checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Bug ID: 14465 Summary: Broken umlauts/diacritics in feedback of last checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 40650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40650&action=edit Screenshot showing the problem This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13315 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40651&action=edit Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 --- Comment #2 from Amit <amitddng135@gmail.com> --- Commit Body is: -------------------------- Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all a Applying: Bug 14465 - Broken umlauts/diacritics in feedback of last checkout Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Failed to merge in the changes. Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of last checkout When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Amit from comment #2)
Patch failed at 0001 Bug 14465 - Broken umlauts/diacritics in feedback of
It's for 3.18.x branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 --- Comment #4 from Amit <amitddng135@gmail.com> --- oh! sorry will test on 3.18.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40651|0 |1 is obsolete| | --- Comment #5 from Amit <amitddng135@gmail.com> --- Created attachment 40655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40655&action=edit Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40655|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 40656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40656&action=edit [SIGNED-OFF] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, no errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Amit from comment #4)
oh! sorry will test on 3.18.x
I win :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #7)
(In reply to Amit from comment #4)
oh! sorry will test on 3.18.x
I win :)
No, you did, I'll obsolete my patch Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40655|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40656|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40655|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 40679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40679&action=edit [PASSED QA][3.18.x] Bug 14465 - Broken umlauts/diacritics in feedback of last checkout This was tested in 3.18 after upgrading to the security release. The feedback on the last checkout information introcuded by bug 13315 has encoding problems in the displayed title (see screenshot). This is a really prominent place to display broken encoding. Test Plan: 1) Apply this patch 2) Check out an item with broken encoding 3) Note the title now displays properly Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> We already put it in production... so this better works :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is only for 3.18.x! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14465 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org