[Bug 31112] New: Able to renew checkout when the number of holds exceeds available number of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Bug ID: 31112 Summary: Able to renew checkout when the number of holds exceeds available number of items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If AllowRenewalIfOtherItemsAvailable is set to Allow we are incorrectly (against the syspref description) allowing to renew some checkouts when the holds are coming from a single patron. When there is only 1 available item for checkout in the biblio and a single patron has made 2 biblio level holds we allow the patron who has a single item on loan to renew their item and disregard the fact the we are leaving one hold unfilled. According to the AllowRenewalIfOtherItemsAvailable syspref the renewal should only be possible when other items can fill all the unfilled holds. I have made a patch for this and will submit it shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137826&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137827&action=edit Bug 31112: Remove unit test that forces specific internal implementation To test: 1) Make sure tests still pass: $ prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137828&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Text to go in the| |When release notes| |AllowRenewalIfOtherItemsAva | |ilable is set to Allow it | |now correctly takes into | |account all the holds | |instead of just one per | |patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137826|0 |1 is obsolete| | --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137856&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137827|0 |1 is obsolete| | --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137857&action=edit Bug 31112: Remove unit test that forces specific internal implementation To test: 1) Make sure tests still pass: $ prove t/db_dependent/Circulation.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137828|0 |1 is obsolete| | --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 137858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137858&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, signed off. Thanks for this, good improvement. There's a small typo in the test plan - either 2.2. should be: 'Create biblio with two items' or 2.3/2.4 should be: 'Checkout out one item to patron A, one item to patron B, and add two biblio-level holds for patron C'. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137856|0 |1 is obsolete| | Attachment #137857|0 |1 is obsolete| | Attachment #137858|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139492&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139493&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139494&action=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds for all patrons, we can still eject if we have more holds than we do items Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139495&action=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a single call using biblionumbers Fetching each individually could be a performance hit on systems with large numbers of holds Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- I reinstated the test for early exit - this is still a valid performance boost - we can't fill all holds if we don't have enough items Also added a prefetch to avoid single calls for each borrower Kyle is going to followup after me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #13 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Thanks for the review Nick! :) (In reply to Nick Clemens from comment #12)
I reinstated the test for early exit - this is still a valid performance boost - we can't fill all holds if we don't have enough items
OK, works for me. I didn't know it was for performance reasons and seems to make the logic not work correctly. I could open another bug report to fix this as I feel like we need some better way to make it more performant while still keeping the check correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take frozen holds into account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 69/75 # Failed test 'Can renew' # at t/db_dependent/Holds.t line 1528. # Failed test 'Item is on non priority hold' # at t/db_dependent/Holds.t line 1529. # got: 'on_reserve' # expected: undef # Looks like you failed 2 tests of 6. t/db_dependent/Holds.t .. 71/75 # Failed test 'non priority holds' # at t/db_dependent/Holds.t line 1556. t/db_dependent/Holds.t .. 75/75 # Looks like you failed 1 test of 75. t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/75 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 256 Tests: 75 Failed: 1) Failed test: 71 Non-zero exit status: 1 Files=1, Tests=75, 7 wallclock secs ( 0.03 usr 0.01 sys + 5.04 cusr 0.68 csys = 5.76 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #15 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139622&action=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from bug 31112 when CheckReserves returned a non-priority hold we didn't return "on_reserve" status but checked in addition to that whether there are any priority holds and if there were, only then we returned the "on_reserve" error. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #16 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139623&action=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's possible that there could be 0 possible reserves, for example when the hold has already been filled, thus the check would fail as the item count can never be less than 0. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #17 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Thanks Kyle for spotting the failing test. I fixed the issue by restoring the previous check that I had accidentally removed (btw, the check looks somewhat buggy actually but that's for another bug report). There was also a small issue with the follow-up patch from Nick, added a fix for that too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139492|0 |1 is obsolete| | Attachment #139493|0 |1 is obsolete| | Attachment #139494|0 |1 is obsolete| | Attachment #139495|0 |1 is obsolete| | Attachment #139622|0 |1 is obsolete| | Attachment #139623|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139729&action=edit Bug 31112: Remove unnecessary if-clause To test: 1) Please check manually that the logic stays the same, use git's -w command line parameter to ignore whitespace changes in the diff output. 2) prove t/db_dependent/Circulation.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139730&action=edit Bug 31112: CanBookBeRenewed: take into account patrons with more than 1 hold to a biblio If a single patron had more than 1 hold to a biblio and there was only one available item we allowed incorrectly renewing the checkout when AllowRenewalIfOtherItemsAvailable was set to "Allow". This changes CanBookBeRenewed so that it makes sure all the holds are filled and not just one per patron. To test: 1) prove t/db_dependent/Circulation.t 2) (Optional, as unit test is provided) - Set AllowRenewalIfOtherItemsAvailable = Allow - Create biblio with three items - Checkout one item to patron A - Add two biblio-level holds for patron B - Try to renew patron A's checkout with and without this patch. - Notice that without this patch the renewal succeeds even though we one unfilled hold left. After applying the patch the renewal should fail. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139731&action=edit Bug 31112: (QA follow-up) Restore check to avoid extra processing We now count all holds for all patrons, we can still eject if we have more holds than we do items Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139732&action=edit Bug 31112: (QA follow-up) Fetch patrons with reserves Previously we fetched all in a single call using biblionumbers Fetching each individually could be a performance hit on systems with large numbers of holds Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139733&action=edit Bug 31112: (follow-up) Bring back the check for non-priority holds Before the changes from bug 31112 when CheckReserves returned a non-priority hold we didn't return "on_reserve" status but checked in addition to that whether there are any priority holds and if there were, only then we returned the "on_reserve" error. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139734&action=edit Bug 31112: (follow-up) Don't return "on_reserve" when there are 0 possible holds It's possible that there could be 0 possible reserves, for example when the hold has already been filled, thus the check would fail as the item count can never be less than 0. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 139735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139735&action=edit Bug 31112: (QA follow-up) Reduce database queries Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #27 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This one brings in conflicts because of "UseRecalls" present in 22.05 (and not 21.11.x). It is not easy to backport, I'm afraid to miss the logic here. Can I get some help with a backport patch for 21.11? Wont backport unless provided. Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32878 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 [Bug 32878] Make it impossible to renew the item if it has active item level hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa@koha-suomi.fi --- Comment #28 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- This is already pushed to stable but I think the AllowRenewalIfOtherItemsAvailable syspref is misleading, there is nowhere information that other items should fill all the unfilled holds. Our superlibrarians have activated this and they are reporting that it is not working. The bug name also indicates that renewal should be possible when holds exceeds available items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Johanna Räisä from comment #28)
This is already pushed to stable but I think the AllowRenewalIfOtherItemsAvailable syspref is misleading, there is nowhere information that other items should fill all the unfilled holds. Our superlibrarians have activated this and they are reporting that it is not working.
The bug name also indicates that renewal should be possible when holds exceeds available items.
Hi Johanna, can you file a new bug, describing the behaviour your librarians are seeing vs what they expect to see? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31112 --- Comment #30 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Nick Clemens from comment #29)
(In reply to Johanna Räisä from comment #28)
This is already pushed to stable but I think the AllowRenewalIfOtherItemsAvailable syspref is misleading, there is nowhere information that other items should fill all the unfilled holds. Our superlibrarians have activated this and they are reporting that it is not working.
The bug name also indicates that renewal should be possible when holds exceeds available items.
Hi Johanna, can you file a new bug, describing the behaviour your librarians are seeing vs what they expect to see?
I will do that. I was also a bit confused how this feature should work. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org