https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #30)

(In reply to Nick Clemens from comment #27)

1) We have built on the fact that the not-for-loan works the same on item type as on individual level and I think this change might be controversial.

Good point, last patch restores postive statuses to the 'green' section. Itemtype notforloan get 'Not for loan' as description and will lump with any others with same description

2) The display with the extra break looks like we are missing a label (I think it's intended, but that's the impression I get)

The line break was always there for Checked Out or On Order items, so I opted to preserve it. Negative not for loan are on this line as they were all 'On order' before - the negative seeming to imply 'holdable' but not 'available'

Just notes (no blockers at all):

I see that you use individual CSS classes on the items, I like that. Just wondering: currently we use the description, so a description change will mean the CSS needs to change as well. On the other side: not for loan values are numeric and we are grouping the onces with the same name and I like that - so that's probably the best way.

Excellent, I think you agree with me here that grouping by description is good. It allows for staff to have two separate values with differing descriptions that show the same on the opac, which I think could have value. -- You are receiving this mail because: You are watching all bug changes.