[Bug 20291] New: Add a StaffLoginInstructions system preference to add text to the staff client login box
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Bug ID: 20291 Summary: Add a StaffLoginInstructions system preference to add text to the staff client login box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72174&action=edit Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72174|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72204&action=edit Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You have missed the update to sysprefs.sql! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72253&action=edit Bug 20291: (follow-up) Add sysprefs.sql changes Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72204|0 |1 is obsolete| | Attachment #72253|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73370&action=edit Bug 20291: Add a StaffLoginInstructions preference for adding text to staff client login To test: 1 - Apply patches 2 - Upgrade database 3 - Check the staff client login page, should be no change 4 - Add something to the preferene 5 - It should appear on the login page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73371&action=edit Bug 20291: (follow-up) Add sysprefs.sql changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- StaffLoginInstructions vs NoLoginInstructions That is wrong, I think it should be: NoLoginInstructions for Staff and OPACNoLoginInstructions for OPAC It seems to be the pattern we follow for other prefs. Do not you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The 'no' in the pref for opac never made sense to me. Why not OPACLoginInstructions and (Staff)LoginInstructions? If we are to go and rename. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- I agree with Katrin 'NoLoginInstructions' is very awkward, StaffLoginInstructions and OPACLoginInstructions if much more clear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73413&action=edit Bug 20291: (follow-up) Rename NoLoginInstructions to OpacLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, you need to s/NoLoginInstructions/OpacLoginInstructions/g correctly :) Double-check the following files: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73413|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73435&action=edit Bug 20291: (follow-up) Rename NoLoginInstructions to OpacLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should make a note about the named syp pref in the release notes, but fully agree with the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backporting to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org