[Bug 39550] New: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Bug ID: 39550 Summary: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I was going to document bug 23295, and noticed the new system preference is under the Patron relationships section. I feel like that's not the right place for it. But there doesn't seem to be a fitting section for it either. Here are some options I thought about 1. Create a "Patron restrictions" section - either with only this one, or we could move a couple of other ones too like useDischarge 2. Place the pref under "General" 2. Place under "Notices and notifications" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 [Bug 23295] Automatically debar patrons if SMS or email notice fail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> ---
2. Place under "Notices and notifications"
Was supposed to be 3. ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Option 1 makes sense to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 180614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180614&action=edit Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section This patch changes the RestrictPatronsWithFailedNotices system preference from the Patron relationships subsection of the Patron preferences to a newly created Patron restrictions subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > Patrons --> There should be a new section called 'Patron restrictions' with RestrictPatronsWithFailedNotices in it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180614|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 180622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180622&action=edit Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section This patch changes the RestrictPatronsWithFailedNotices system preference from the Patron relationships subsection of the Patron preferences to a newly created Patron restrictions subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > Patrons --> There should be a new section called 'Patron restrictions' with RestrictPatronsWithFailedNotices in it Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Päivi Knuutinen <paivi.knuutinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paivi.knuutinen@joensuu.fi --- Comment #5 from Päivi Knuutinen <paivi.knuutinen@joensuu.fi> --- It works as planned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|unspecified |Main QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't forget to set assignee :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #6)
Don't forget to set assignee :)
Sorry, I think I will always forget! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This moves the system release notes| |preference | |`RestrictPatronsWithFailedN | |otices' into the right | |section of the system | |preferences editor. Summary|RestrictPatronsWithFailedNo |RestrictPatronsWithFailedNo |tices system preference |tices system preference |should not be in Patron |should not be in patron |relationships section |relationships section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #9 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Suggestions for the future follow-up bug: move CumulativeRestrictionPeriods and PatronRestrictionTypes out of Circulation > Patron restrictions to the new Patrons > Patron restrictions section. Maybe get rid of Circulation > Patron restrictions altogether by moving the remaining two system preferences to the Checkin policy / Checkout policy sections? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Bug 39550 depends on bug 23295, which changed state. Bug 23295 Summary: Automatically debar patrons if SMS or email notice fail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39550 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Aude Charillon <aude.charillon@openfifth.co.uk> --- When documenting bug 23295, I added the RestrictPatronsWithFailedNotices system preference to the new Patron restrictions subsection. It's a small enough change between versions 24.11 and 25.05 that I don't think the Manual needs a note. Do re-open this bug if you think differently. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org