https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |J.P.Knight@lboro.ac.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- I tried to sign the patch using the Biblibre's sandbox #3 yesterday and this morning but always get this message : "It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 68972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68972&action=edit Bug 19479: Patch to format totals according to the CurrencyFormat syspref. On the page acqui/basketgroup.pl the prices of baskets should be shown according to the selected CurrencyFormat syspref. Test plan: 1) Create some baskets with items in them. 2) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 3) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 2. https://bugs.koha-community.org/show_bug.cgi?id=19479 Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The price formatting must be done template side, search for '$Price' or '[% USE Price %]' in **/*.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68972|0 |1 is obsolete| | --- Comment #9 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 71312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71312&action=edit Attempt to display price formatted according to CurrencyFormat syspref using templates, with the English template as an example. 1) Create some baskets with items in them. 2) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 3) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 2. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #11 from Jon Knight <J.P.Knight@lboro.ac.uk> --- One thing to note is that if I use the templates rather than my original patch that just altered basketgroup.pl to do the formatting, I'm guessing that each language that Koha is in will also need its basketgroup.tt template updated? Is that right? I've only done the en (default English) one in this current patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4078 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You should base your patch on top of bug 4078 instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 [Bug 4078] Add the ability to customize and display the symbol for a currency -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #14 from Jon Knight <J.P.Knight@lboro.ac.uk> --- I'll wait until 4078 is in master (its Passed QA at the moment) before changing this patch again just so that I'm aiming for a stable target! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #15 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 73290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73290&action=edit Attempt to display price formatted according to CurrencyFormat syspref using templates, with the English template as an example. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #16 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 73291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73291&action=edit Bug 19479: Display price in basked group formatted according to CurrencyFormat syspref using templates. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Jon, Total: [% selectedbasket.total | $Price %] ([% selectedbasket.currency %]) Will display: 42 (EUR) or 42 (USD) With bug 4078 you can use the with_symbol flag to display the symbol. Total: [% selectedbasket.total | $Price with_symbol => 1 Will display: €42 or $42 I think it is what we want here. Actually what we really want is: "42 €" and "$42", but it's not configurable (yet). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73377|0 |1 is obsolete| | --- Comment #22 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 73379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73379&action=edit Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates and currency symbols. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, using the currency symbol rather than three letter currency code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73379|0 |1 is obsolete| | --- Comment #23 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73491&action=edit Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates and currency symbols. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, using the currency symbol rather than three letter currency code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Séverine, there is no a setting in administration > currency for each currency, where you can define if there should be a space or not. Hi Jon, thank you for your perseverance! 2 small things: If this line is no longer needed, please remove it, instead of commenting out: +# $total .= " " . ($bookseller->invoiceprice // 0); I am torn about seeing the currency. I think we agreed a long while ago that we should not show the currency symbols in acq as long as it's the active currency as it would clutter a lot of the displays, where you deal with a lot of numbers and prices. Would you agree to remove the currency symbol display? $Price with_symbol => 1 Please switch back to signed off if you add a follow up patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jon Knight from comment #26)

(In reply to Katrin Fischer from comment #25)

...

Hi Séverine, there is no a setting in administration > currency for each currency, where you can define if there should be a space or not.

I am torn about seeing the currency. I think we agreed a long while ago that we should not show the currency symbols in acq as long as it's the active currency as it would clutter a lot of the displays, where you deal with a lot of numbers and prices. Would you agree to remove the currency symbol display? $Price with_symbol => 1

That's how I had it before Jonathan Druart asked me to put the symbols in place in comment #18 above. I don't mind either way as long as the QA team and RM can agree (or do I have to add in a syspref for this? :-) ).

I'll await a decision before changing this simple patch again.

IIRC you displayed the currency code :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #29 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 73677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73677&action=edit Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, with no currency symbol or code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #31 from Jon Knight <J.P.Knight@lboro.ac.uk> --- (In reply to Katrin Fischer from comment #30)

Hi Jon, if QA demands a follow-up what you can usually do is make a small extra patch with the additional changes and attach it. In this case it would have just been removing the attribute. This way you can keep the sign-off on your first patch and the signed-off status and it goes directly back to QA. Do you want to change it and restore the signed off patch with a little addition?

No, because the last patch changed the behaviour (again), rather than just being a small change to get rid of the commented out line. That really needs someone to check that it is what people actually want and sign that off (again). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #34 from Séverine Queune <severine.queune@bulac.fr> --- This price display seems clearer to me even though we don't have currency symbols. As user, this patch is good for me :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74274|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74284&action=edit Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, with no currency symbol or code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed some tabs. https://bugs.koha-community.org/show_bug.cgi?id=19497 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So we should remove the 2x2 lines you add in the .pl to retrieve the active currency, right? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jon Knight from comment #38)

Ah that's a good point. Do you want me to generate a new patch without them?

I will do it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.