[Bug 25115] New: Use get_effective_rule for getting rental discount
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Bug ID: 25115 Summary: Use get_effective_rule for getting rental discount Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org We have this logic for searching rentaldiscount rule https://github.com/Koha-Community/Koha/blob/6ac037f817def256c85706413036bee3... Why? This is against documentation on sorting order of circulation rules in the user interface. Use Koha::CirculationRules->get_effective_rule() instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 102769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102769&action=edit Bug 25115: Use get_effective_rule for getting rental discount -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Added a proposed patch if this Bug is valid. GetIssuingCharges() seems to have no unit test, could someone generate one for this? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Can you please provide a test plan for the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25115 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 26593 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org