[Bug 11201] New: List pending in-house uses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Bug ID: 11201 Summary: List pending in-house uses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10860, 10859 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22718&action=edit Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Tried applying this patch in a sandbox and got this message: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11201: <h1>Something went wrong !</h1>Applying: Bug 11201: Add a in-house use list pages fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11201: Add a in-house use list pages When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11201 - List pending in-house uses 22718 - Bug 11201: Add a in-house use list pages Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11201-Add-a-in-house-use-list-pages-69ntjD.patch . Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Christopher Brannon from comment #2)
Tried applying this patch in a sandbox and got this message:
This patch depends on bug 10859 and bug 10860. You must apply them before applying this one. That cannot be done with a sandbox. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22718|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31391&action=edit Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31392&action=edit Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Bug 11201 depends on bug 10859, which changed state. Bug 10859 Summary: Alert if a patron already has an issue for the same biblio http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31391|0 |1 is obsolete| | Attachment #31392|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31666&action=edit Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- There a couple of things I would like to see added if possible: - Output of subtitles as defined in Keyword to MARC mapping - Overdue items highlighted in red as they are on the checkouts page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33185&action=edit Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #7)
- Output of subtitles as defined in Keyword to MARC mapping
I don't want to add to much information on this table. But this could be done later if needed.
- Overdue items highlighted in red as they are on the checkouts page
Done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- I am not seeing anything on my on site checkouts page and I do have an item checked out for onsite. Is there something else I need to do? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33185|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36278&action=edit Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Nicole C. Engard from comment #10)
I am not seeing anything on my on site checkouts page and I do have an item checked out for onsite. Is there something else I need to do?
Sorry Nicole, there was a syntax error in the sql query. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31666|0 |1 is obsolete| | --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36471&action=edit [SIGNED-OFF] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36475&action=edit [SIGNED-OFF] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. Signed-off-by: Nicole <nicole@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|List pending in-house uses |List pending in-house | |checkouts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11201: Display overdues in red fatal: sha1 information is lacking or useless (C4/Circulation.pm). ... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Should be good now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 36471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36471 [SIGNED-OFF] Bug 11201: Add a in-house use list pages Review of attachment 36471: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11201&attachment=36471) ----------------------------------------------------------------- Tiny tiny things... :) ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt @@ +46,4 @@
systems with large numbers of overdue items.</li>[% END %] <li> <a href="/cgi-bin/koha/circ/branchoverdues.pl">Overdues with fines</a> - Limited to your library. See report help for other details.</li> <!-- <li> <a href="/cgi-bin/koha/circ/stats.pl?time=yesterday">Daily reconciliation</a></li> --> + <li><a href="/cgi-bin/koha/circ/on-site_checkouts.pl">On-site checkout list</a></li>
Hi Jonathan, can you please make the visibility of the link depend on the system preference? ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/on-site_checkouts.tt @@ +40,5 @@
+<div id="doc3" class="yui-t2"> + <div id="bd"> + <div id="yui-main"> + <div class="yui-b"> + <h4>Pending on-site checkout list</h4>
I think this should be <h1> as on the other pages - otherwise the 'no pending...' message is bigger than the heading. After discussing with Nicole it would be nice if the circulation start page and the heading both said: Pending on-site checkouts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36646&action=edit Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36646|0 |1 is obsolete| | --- Comment #19 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36663&action=edit Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36914&action=edit [PASSED QA] Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. Bug 11201: Display lib instead of AV code This patch assumes that items.location is linked the the LOC authorised values. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36915&action=edit [PASSED QA] Bug 11201: Display overdues in red On the pending on-site checkout list, the date for overdues are now displayed in red. Test plan: Make sure you have on-site checkouts created today and before. The date for the ones created before today should be displayed in red. Signed-off-by: Nicole <nicole@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36916&action=edit [PASSED QA] Bug 11201: qa-followup - move h4 to h1 - Make the link on the circ home page depending on the pref Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 36917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36917&action=edit Bug 11201 - QA follow-up - Pending on-site checkouts Changes page name to "Pending on-site checkouts" as agreed during the hackfest. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org