https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patches apply right now, but 3 things: 1) there are still no unit tests for the changes to the core routine 2) if we decide to have a system preference for this kind of behaviour, I'd suggest to rename it from AcqLateOrderUseCreationDate to AcqLaterOderDefaultSort which be more descriptive. 3) The SQL in sysprefs.sql is wrong: FAIL installer/data/mysql/sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 6 OK sysprefs_order I agree with previous commenters that it doesn't seem quite right to switch the dates in the column like this. I'd like it if both were shown and the sorting handled by JavaScript. I think it would add valuable information and allow for more flexibility. -- You are receiving this mail because: You are watching all bug changes.