[Bug 34977] New: The "Patron Lists" only allows deleting one list at a time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Bug ID: 34977 Summary: The "Patron Lists" only allows deleting one list at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: salah.ghedda@inlibro.com QA Contact: testopia@bugs.koha-community.org Instead of deleting one list at a time, it's more helpful to be able to delete multiple lists at once by adding checkboxes for each list along with a button (at the bottom or top of the page) to enable the deletion of multiple lists at once. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |salah.ghedda@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #1 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 156553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156553&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156553|0 |1 is obsolete| | --- Comment #2 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 156554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156554&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete one list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156554|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156562&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |selecting and deleting | |multiple patron lists at | |once, instead of having to | |delete patron lists one at | |a time. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156562|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158349&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158350&action=edit Bug 34977: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Would be nice if there was a select all button, but not a blocker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The "Patron Lists" only |The "Patron lists" only |allows deleting one list at |allows deleting one list at |a time |a time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The "Patron lists" only |Allow to delete multiple |allows deleting one list at |patron lists at once |a time | Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158349|0 |1 is obsolete| | --- Comment #9 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 159483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159483&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158350|0 |1 is obsolete| | --- Comment #10 from Salah Ghedda <salah.ghedda@inlibro.com> --- Created attachment 159484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159484&action=edit Bug 34977: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #11 from Salah Ghedda <salah.ghedda@inlibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/781 Resolution|--- |FIXED Keywords|release-notes-needed | Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- - return confirmDelete( _("Are you sure you want to delete the list %s?").format(list) ); + return confirmDelete( _("Are you sure you want to delete the list %s?").format(list)); This change is wrong, unnecessary and causes conflict! Please avoid them and catch them before push! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #13 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. Please check bug 36132 for more details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #14 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Bug 34977 prevented users from deleting multiple patron lists from the 2nd page onwards. Please check bug 36132 for more details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29830 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org