[Bug 12375] New: Store serials enumeration data in separate fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Bug ID: 12375 Summary: Store serials enumeration data in separate fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- *** Bug 8956 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28675&action=edit Bug 12375 [1] - Update database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28676&action=edit Bug 12375 [2] - Update Serial schema file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28677&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28678&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28678|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28679&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28675|0 |1 is obsolete| | Attachment #28676|0 |1 is obsolete| | Attachment #28677|0 |1 is obsolete| | Attachment #28679|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28680&action=edit Bug 12375 [1] - Update database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28681&action=edit Bug 12375 [2] - Update Serial schema file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28682&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28683&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28681|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28682|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28843&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28844&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #14 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28845&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 28846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28846&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- If a numbering pattern uses {X}, {X}{Y} or {X}{Y}{Z}, in this order, then the updatedatabase works. But if I have a numbering pattern that uses only {Z} for example, then the Z part will be stored in serialseq_x (and future serials will have the Z part in serialseq_z column) If my numbering pattern uses only {X} and {Z}, the Z part will be in serialseq_y. I think this have to be fixed, so failing QA here. Also the original serialseq column is not removed. Is it intended ? I think we should not keep values in database that can be easily generated on the fly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29928&action=edit 28846 - Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29928|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29929&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Julian Maurice from comment #16)
If a numbering pattern uses {X}, {X}{Y} or {X}{Y}{Z}, in this order, then the updatedatabase works. But if I have a numbering pattern that uses only {Z} for example, then the Z part will be stored in serialseq_x (and future serials will have the Z part in serialseq_z column) If my numbering pattern uses only {X} and {Z}, the Z part will be in serialseq_y. I think this have to be fixed, so failing QA here.
Fixed! The attached qa followup should allow the database update to handle these situations.
Also the original serialseq column is not removed. Is it intended ? I think we should not keep values in database that can be easily generated on the fly.
We need to keep the serialseq column, at least for the time being. Right now the new columns are for reporting. In the future we can also use them to improve the sorting of serials. In the long run we may want to deprecate serialseq, but each library would need to go through all their serials to verify the sequence values are correct before upgrading ( that is, the values may have been migrated from a previous ILS and need to be updated ). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Ok, it works well now, but it generates a lot of warnings Use of uninitialized value $indexes[1] in hash element at installer/data/mysql/updatedatabase.pl line 8605. Use of uninitialized value $indexes[2] in hash element at installer/data/mysql/updatedatabase.pl line 8605. ... line 8605 for me is... ( undef, $enumeration_data{ $indexes[0] }, # <= ... here $enumeration_data{ $indexes[1] }, $enumeration_data{ $indexes[2] } ) = split( /__SPLIT__/, $serialseq ); Could you fix that, please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28843|0 |1 is obsolete| | Attachment #28844|0 |1 is obsolete| | Attachment #28845|0 |1 is obsolete| | Attachment #28846|0 |1 is obsolete| | Attachment #29929|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30099&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30100&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30101&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30102&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30103&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30104&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- This new followup should suppress those warnings. Please give it a try! (In reply to Julian Maurice from comment #20)
Ok, it works well now, but it generates a lot of warnings
Use of uninitialized value $indexes[1] in hash element at installer/data/mysql/updatedatabase.pl line 8605. Use of uninitialized value $indexes[2] in hash element at installer/data/mysql/updatedatabase.pl line 8605. ...
line 8605 for me is...
( undef, $enumeration_data{ $indexes[0] }, # <= ... here $enumeration_data{ $indexes[1] }, $enumeration_data{ $indexes[2] } ) = split( /__SPLIT__/, $serialseq );
Could you fix that, please ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Great! Thanks. koha-qa is only complaining about a trailing whitespace in updatedatabase.pl which I'll fix in a follow-up patch. Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 30108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30108&action=edit Bug 12375: QA followup - remove trailing whitespace -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30099|0 |1 is obsolete| | Attachment #30100|0 |1 is obsolete| | Attachment #30101|0 |1 is obsolete| | Attachment #30102|0 |1 is obsolete| | Attachment #30103|0 |1 is obsolete| | Attachment #30104|0 |1 is obsolete| | Attachment #30108|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35155&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35156&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35157&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35158&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35159&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35160&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35161&action=edit Bug 12375: QA followup - remove trailing whitespace -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Kyle, could you please rebase this one? The updatedatabase patch was easy, but C4/Serials.pm got a bit more complicated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35155|0 |1 is obsolete| | Attachment #35156|0 |1 is obsolete| | Attachment #35157|0 |1 is obsolete| | Attachment #35158|0 |1 is obsolete| | Attachment #35159|0 |1 is obsolete| | Attachment #35160|0 |1 is obsolete| | Attachment #35161|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40710&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40711&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40712&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40713&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40714&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40715&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40716&action=edit Bug 12375: QA followup - remove trailing whitespace -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40710|0 |1 is obsolete| | Attachment #40711|0 |1 is obsolete| | Attachment #40712|0 |1 is obsolete| | Attachment #40713|0 |1 is obsolete| | Attachment #40714|0 |1 is obsolete| | Attachment #40715|0 |1 is obsolete| | Attachment #40716|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46122&action=edit Bug 12375 [1] - Update database Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46123&action=edit Bug 12375 [2] - Update Serial schema file Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46124&action=edit Bug 12375 [3] - Store serials enumeration data in separate fields Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46125&action=edit Bug 12375 [4] - Replace use of DBI with Koha::Database in C4::Serials::NewIssue Currently, all serials enumeration data is stored in conglomerated fashion in serial.serialseq. This makes it extremely difficult to do any reporting based on the individual sequence values due to this fact. In addition to the formatted version of the sequence, we should be storing the individual values as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field. 4) Inspect some existing serials. The update script will have made a best effort to recover the existing enumeration data to store in separate fields. Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46126&action=edit Bug 12375 [5] [QA Followup] - Don't assume X Y and Z are used in order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46127&action=edit Bug 12375 [6] [QA Followup] - Supress warnings for undefined indexes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46128&action=edit Bug 12375 [7] - Update to use Koha::Object classes This code was written before the introduction of Koha::Object(s) Considering the triviality of updating the code, we should go ahead and switch this code to use Koha::Object(s) now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46319&action=edit Bug 12375 - Add new serial fields to kohastructure -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org