[Bug 13377] New: automatic_renewals.pl not marked executable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Bug ID: 13377 Summary: automatic_renewals.pl not marked executable Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: swarren@wwwdotorg.org QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz root@leibniz:/etc/cron.daily# ./koha-common library: env: /usr/share/koha/bin/cronjobs/automatic_renewals.pl: Permission denied root@leibniz:/etc/cron.daily# ls -l /usr/share/koha/bin/cronjobs/automatic_renewals.pl -rw-r--r-- 1 root root 1747 Nov 30 15:54 /usr/share/koha/bin/cronjobs/automatic_renewals.pl The file is 644 but should presumably be 755 since /etc/cron.daily/koha-common attempts to execute it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11577 Depends on| |11577 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 34081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34081&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- This is important enough for the packages to work correctly that I'm going to push it through QA. I've build squeeze-dev packages with it in, and it looks like it did the trick. It should be in the next 3.18 release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Workaround until the next version is released (so I can point people here if it comes up on lists etc): sudo chmod +x /usr/share/koha/bin/cronjobs/automatic_renewals.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #4 from Stephen Warren <swarren@wwwdotorg.org> --- One the script is marked executable, it still has problems; there's no #! line at the top. Once that's added, the script seems to run without obvious problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34081|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 34082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34082&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34082|0 |1 is obsolete| | --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 34083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34083&action=edit Bug 13377: mark automatic_renewals.pl as executable This script is called by a cron job, but was never marked as executable, so will error every time it's called, which is no good. This also adds an appropriate #! line to the top of the file. To test: * apply the patch * make a package * ensure that the installed /usr/share/koha/bin/cronjobs/automatic_renewals.pl is mode 755 and does something when run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> --- Third time lucky, can you have a look and double check that this patch is sensible to you (it's still pretty simple, so I can't imagine much would go wrong.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 --- Comment #8 from Stephen Warren <swarren@wwwdotorg.org> --- The patch in comment 6 looks reasonable; my sysadmin tested out the same changes and saw no obvious issues after making those same changes manually. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13377 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.01, Robin do you think it's worth rolling a new 3.18.0 with just this patch added to it? (It's only 18 days to 3.18.01 ) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org