https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 169491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169491&action=edit Bug 37451 - Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169491|0 |1 is obsolete| | --- Comment #2 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 172020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172020&action=edit Bug 37451 - Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m Status|Signed Off |Failed QA --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked properly, but failed the QA tests: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc FAIL filters missing_filter at line 27 ( [% restriction.type.code %]) The wiki has a section explaining the filter guideline: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_Filter_all_tem... Processing additional checks * Commit title does not start with 'Bug XXXXX: ' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172020|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 176455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176455&action=edit Bug 37451: Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176455|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 176468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176468&action=edit Bug 37451: Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- See bug 14368 for the history feature I was referring to: Test plan: - As a user, ask for a discharge. - As a librarian, allow the discharge. - Check that the requested and validated dates appear on the discharge panel of the borrower in the admin interface. - Lift the discharge debarment of the user. - Check that you can repeat these steps and that the new discharges are added in the discharge panel of the borrower in the admin interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |sonia.bouis@univ-lyon3.fr --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #8)

Hum... I have multiple problems with that FQA

1/ According to our PO, a discharge should not be able to be removed by librarians, and user should not be able to remove it. The correct behaviour would be to create a new borrower. In France in particular, the discharge means that the library account has been closed.

Have you checked the former development from Matthias Meusburger on bug 37344? It's also from Biblibre and it indicates that being able to remove a restriction was intended as we used to show a history. But no matter what: this feature has been in use for many years with the ability to lift the restriction. It's likely to break use cases if changed like that now. I know it would for German libraries.

2/ Atm removing suspension due to discharge is kinda broken, ant it is hard to support it. For example if I remember well, the array you are mentionning... only displays the last discharge. And the account after suspension results in a few minor tweaks on the OPAC, for example Bug 37344. The main issue is that a suspended user with any discharge is considered as discharged.

I agree that it is broken, because the test plan on bug 37344 clearly indicates it should not only show the latest, but all previous discharges. It would be good to investigate that. I believe something broke here and it might explain the problem we are seeing.

I'm a great fan of adding syspref, but maybe we could add one here ?

If a security question is not enough, suggest making this configurable. In this case maybe it could be a new column in the patron restrictions table. This way, we could make this option available to all restrictions onward. But I warn about it not being removable from staff interface at all, because I am almost sure it will create issues. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176468|0 |1 is obsolete| | --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179392&action=edit Bug 37451: Remove the ability to delete a restriction due to discharge However it is not possible to remove the discharge, it is possible to remove the suspension associated to the discharge. This can lead to a lot of undesired behaviors when the user asks for another discharge or get suspended for another reason. Suspension due to discharge should therefore be definitive. TEST PLAN: 1 - Go to patron -> pick a patron -> go to discharges 2 - Generate a discharge for the patron 3 - Go to check out -> restrictions 4 - There should be a restriction with type discharge that can be deleted 5 - Apply patch 6 - There still should be a restriction but the button has been replaced by an infobox 7 - Set the syspref 'DischargeOverride' to 'Allow' and see the button reappeared Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did you investigate the behavior of the discharges page concerning multiple discharges (history)? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- (In reply to Katrin Fischer from comment #12)

Did you investigate the behavior of the discharges page concerning multiple discharges (history)?

Investigations were done multiple monthes ago, the bug is very trivial, AFAIR the line read is always stored in the same variable and not pushed in a new line of the array. Concerning a patch proposal, I hope being able to submit a correction for wednesday, in a separate patch, we have a Koha symposium on french community. However, I'll work Bug 37344 before, since it will be impacted by a fix on the multiple lines -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- @Katrin, with Bug 37344 and Bug 39369 in mind do you consider we still should allow removing *the restriction* due to discharge ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #18 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Hello, just to say that we should have a way to cancel a discharge if it's a mistake. (we already had the case of students that haden't really understand what it is and asked a discharge by mistake) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37344 [Bug 37344] Patrons with cancelled discharge are seen as discharged when suspended due to overdue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #21 from Sonia Bouis <sonia.bouis@univ-lyon3.fr> --- Ok to look together in Marseille -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |BLOCKED --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- As discussed this morning with @Katrin, I set this to the blocked state, waiting for the main patch to be validated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37451 --- Comment #24 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Note: Follow up has been removed due to our discussion also (it makes no sense with Bug 37344) and test plan has been updated again. Since it had already been QAed with this test plan, it can reasonably be passed to PQA after 37344 is pushed to main -- You are receiving this mail because: You are watching all bug changes.