[Bug 16780] New: Specify due date always sets time as AM when using 12 hour time format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Bug ID: 16780 Summary: Specify due date always sets time as AM when using 12 hour time format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - On the checkout screen for a patron specify a due date and a PM time 2 - Checkout an item 3 - Note the due date for the item and the time in the box have switched to AM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten@switchinc.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16624 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, I confirm the issue. This is a tricky one, it's because the AM/PM breaks the parsing of the dates somewhere. Do you know if it's a regression from a previous stable version or if it has never worked? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 --- Comment #2 from Karl Holten <kholten@switchinc.org> --- It's a regression, it used to work for our institutions before our update to 3.22. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14903 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comes from 165 $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); } 166 if ( $duedatespec ); Introduced by commit 421fae24f1cdcbe0ccc18de784454d0ca07ebe90 Bug 14903: Remove C4::Dates from circ/circulation.pl (and more) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 [Bug 14903] Remove C4::Dates from circ/circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52781&action=edit Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Smart fix, I did not think about that! Will QA it as soon as it's signed off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52781|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 52884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52884&action=edit Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52884|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52896&action=edit Bug 16780 - Specify due date always sets time as AM when using 12 hour time format This regression is occurs because the time format for the checkout date/time widget is only meant to be given in 24 hour format. The time due should not be converted to 12 hr time even if the library has 12 hour set as their preferred time format. Test Plan: 1) Performat a backdated checkout with a date due that has a PM time 2) Note the date/time picker on the confirmition screen shows the time in AM/PM 2) Note the time is not stored correctly 3) Apply this patch 4) Repeate step 1 5) Note the confirmation date/time picker now show the time in 24hr format 6) Note the time was stored correctly Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Assignee|kyle@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 --- Comment #9 from J Schmidt <jschmidt@switchinc.org> --- Can we have this backported to 3.22? One of our branches has hourly equipment and it impacts a great portion of their checkout transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25133 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org