[Bug 29129] New: The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Bug ID: 29129 Summary: The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The printclearscreen icon which appears when the system preference 'DisplayClearScreenButton' should allow users to choose between printing the ISSUESLIP and ISSUEQSLIP, if that system pref is turned on. I think the 'DisplayClearScreenButton' could have 3 options: -Don't show -Show and print ISSUESLIP -Show and print ISSUEQSLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 134175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134175&action=edit Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134175|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 134176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134176&action=edit Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to run QA test tools: OK circ/circulation.pl FAIL installer/data/mysql/atomicupdate/bug29129.pl FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The printclearscreen icon |The clear screen and print |on circulation.tt should be |icons in circulation should |configuarable to print |be configuarable to print |either ISSUESLIP or |either ISSUESLIP or |ISSUEQSLIP |ISSUEQSLIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134176|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134282&action=edit Bug 29129: Update DisplayClearScreenButton to allow for a choice between issueslip and issueqslip To Test: 1. Apply patch, updatedatabase, and restart_all 2. A small change the global scss file means you should regenerate the CSS as well. ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Set DisplayClearScreenButton to "don't show" 4. Go to the patron checkout screen and see that no button should show to clear the screen and print 5. Set DisplayClearScreenButton to 'ISSUESLIP' and make sure the button now appears and the ISSUESLIP prints 6. Set DisplayClearScreenButton to 'ISSUEQSLIP' and make sure the button now appears and the ISSUEQSLIP prints Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134283&action=edit Bug 29129: (QA follow-up) Add +x to atomicupdate permissions Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134284&action=edit Bug 29129: (QA follow-up): Fix tiny typo in system preference description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134285&action=edit Bug 29129: (QA follow-up) Rephrasing DisplayClearScreenButton preference Trying to make it clearer that's either none or 2 buttons. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, maybe you can have a look at my last follow-up and let me know if that works for you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP This will avoid a new system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #10)
Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP This will avoid a new system preference.
I will rework this to just always show all 3, without a sys pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #11)
(In reply to Fridolin Somers from comment #10)
Why not always showing 3 buttons : CANCEL, ISSUESLIP, ISSUEQSLIP This will avoid a new system preference.
I will rework this to just always show all 3, without a sys pref.
We already have the pref, so it's just a new option to an existing one. I feel that libraries have prefernces about the slips and we'd need really clear icons for full and quick slip printing. Not sure if that would not be worth to be discussed/done later and let this in as a small change to an already existing feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> ---
We already have the pref, so it's just a new option to an existing one.
Ohhh i totally missed that. In this case OK to add a new option, sure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136551&action=edit Bug 29129: (QA follow-up) Tidy atomicupdate Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement expands release notes| |upon the | |'DisplayClearScreenButton' | |allowing the choice of | |printing either the | |ISSUESLIP or the ISSUEQSLIP | |when using the | |printclearscreen icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/616 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Keywords|release-notes-needed, | |rel_22_11_candidate | CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr Summary|The clear screen and print |The clear screen and print |icons in circulation should |icons in circulation should |be configuarable to print |be configurable to print |either ISSUESLIP or |either ISSUESLIP or |ISSUEQSLIP |ISSUEQSLIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34684 [Bug 34684] 220600007.pl is failing if run twice -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org