https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49727&action=edit Bug 16177: Fix tests for ColumnsSsettings.t This failure has been introduced by commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files This is because the cannot_be_modified key is not always created by C4::Utils::DataTables::ColumnsSettings subroutines Test plan: prove t/db_dependent/ColumnsSettings.t should return green And you can also test a table where the feature is set and a column cannot be modified from the admin page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49727|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49765&action=edit Bug 16177: Fix tests for ColumnsSsettings.t This failure has been introduced by commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files This is because the cannot_be_modified key is not always created by C4::Utils::DataTables::ColumnsSettings subroutines Test plan: prove t/db_dependent/ColumnsSettings.t should return green And you can also test a table where the feature is set and a column cannot be modified from the admin page. NOTE: Works as described. I was pondering this potential solution when I found it in bugzilla. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49765|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49773&action=edit Bug 16177: Fix tests for ColumnsSsettings.t This failure has been introduced by commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files This is because the cannot_be_modified key is not always created by C4::Utils::DataTables::ColumnsSettings subroutines Test plan: prove t/db_dependent/ColumnsSettings.t should return green And you can also test a table where the feature is set and a column cannot be modified from the admin page. NOTE: Works as described. I was pondering this potential solution when I found it in bugzilla. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16177 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.