[Bug 7576] New: Add ISSN to SearchForTitleIn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Bug #: 7576 Summary: Add ISSN to SearchForTitleIn Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com Currently we only support ISBN, but not ISSN in the SearchForTitleIn system preference: "Include a "More Searches" box on the detail pages of items on the OPAC, with the following HTML (leave blank to disable): Note: The placeholders {BIBLIONUMBER}, {CONTROLNUMBER}, {TITLE}, {ISBN} and {AUTHOR} will be replaced with information from the displayed record." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-23 22:59:05 UTC --- Created attachment 7842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7842 Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7842|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-23 23:06:49 UTC --- Created attachment 7843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7843 Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7843|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2012-02-24 09:55:28 UTC --- Created attachment 7850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7850 Bug 7576: Add ISSN to SearchForTitleIn preference Adds a new placeholder {ISSN} to the system preference SearchForTitleIn. For a record with multiple ISSNs only the first ISSN will be used. Addition: Makes a small change to GetMarcControlnumber so that it checks for NORMARC too. If you set your system preference to NORMARC, it should output {CONTROLNUMBER} correctly now. For testing add following code to the system preference and check output of SearchForTitleIn for different records in your OPAC and all 3 available views (normal, MARC and ISBD): <li>ISSN: {ISSN}</li> <li>ISBN: {ISBN}</li> <li>001: {CONTROLNUMBER}</li> Patch also includes some unit tests: perl t/db_dependent/Biblio.t Signed-off-by: Magnus Enger <magnus@enger.priv.no> Tested with marcflavour = NORMARC, on one book and one periodical record. * Book - Before the patch: ISSN: {ISSN} ISBN: 0375726446 001: - After the patch: ISSN: ISBN: 0375726446 001: 022976914 * Journal - Before the patch: ISSN: {ISSN} ISBN: 001: - After the patch: ISSN: 1890-6931 ISBN: 001: 080721370 Looks good in all 3 views! Thanks for fixing the 001 thing for NORMARC! Also tested with marcflavour = MARC21, on the same records with the same good results. Signing off! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus@enger.priv.no -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> 2012-02-24 20:33:13 UTC --- Clean, consistent patch with unit tests. Fixes some grammar in the notes, and also fixes NORMARC support for 001. All in all, a MARVELOUS patch. Marking Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 10:46:20 UTC --- patch pushed, after testing it also work fine for UNIMARC chris_n = I wouldn't object if you decided to apply this for 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7576 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org