[Bug 35773] New: Cannot create bookings without circulation permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Bug ID: 35773 Summary: Cannot create bookings without circulation permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, jonathan.druart+koha@gmail.com, kyle.m.hall@gmail.com, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 29002 When attempting to place a booking on an item in the catalogue a user needs several permissions: 1 - Patron search permissions (see bug 29509) [Any of "borrowers:edit_borrowers", "tools:label_creator", "serials:routing", "acquisition:order_manage"] 2 - circulate: manage_bookings 3 - circulate_ circulate_remaning_permissions If you don't have one of the first, the loading of patrons seems dies on looking up patrons via the api Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29509 | Blocks| |29509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29509 [Bug 29509] GET /patrons* routes permissions excessive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 160876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160876&action=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot create bookings |Cannot create bookings |without circulation |without edit_borrowers, |permissions |label_creator, routing or | |order_manage permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- (In reply to Martin Renvoize from comment #1)
It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly.
Could this bug (35773) be closed now that "Bug 29509 - GET /patrons* routes permissions excessive is "Needs Signoff"? Or is it still needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- They're really meant to be applied in order Magnus. I did that so that we get this important fix in 23.11.x even if we don't backport 29509 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160876|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 162249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162249&action=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. As the koha user, set up an item for booking and place a booking - everything should work as expected: 1.1 Enable an item to be booked: . Go to a record with item(s). . Go to the items tab. . Update an item so that it is bookable (Priority section, update Bookable to 'Yes' 1.2 From the buttons above the title, select 'Place booking': . Choose a patron . Select a period (click a start and end date) . Submit 2. Set up another staff patron (such as Henry) so that: 2.1 You can log in as them. 2.2 They have these permissions: . Staff access, allows viewing of catalogue in staff interface (catalogue) . Check out and check in items (circulate) (including Manage item bookings (manage_bookings)) 3. Log in as them and try to make a booking - note that when searching for the patron name (such as lisa or mary), that you get no search results and can't select a patron. 4. Apply the patch, flush_memcached, and restart everything (restart_all) 5. Try again to make a booking - you should now be able to successfully search for a patron and submit the booking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162249|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162695&action=edit Bug 35773: Add manage_bookings subpermission to patron searching This quickly fixes the issue to allowing those who have the manage_bookings subpermission to also search for users. It's deliberately bare as I'm keen to subsequently remove it again in bug 29509 where we will deal with this properly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) Should circulate_remaning_permissions be needed for bookings? It's the one necessary for the calendar to load in the booking form. Even if there is something to do about it, it's not really for this ticket so still passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35773 Bug 35773 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org