[Bug 5867] New: "Hold filled" notice not sent by email if the user has its email address in a field other than "email"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Bug #: 5867 Summary: "Hold filled" notice not sent by email if the user has its email address in a field other than "email" Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org Created attachment 3304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3304 [PATCH] Improved the email checking when sending "Hold filled" notices. The subroutine for sending HOLD and HOLD_PRINT notices only checked the "email" field of the borrowers table and didn't check the value of the AutoEmailPrimaryAddress preference. With this patch, "Hold filled" notices can now be sent using the other email addresses of the member, depending on the value of the AutoEmailPrimaryAddress preference. Also, if AutoEmailPrimaryAddress is set to "first valid", the other email fields of the user are checked before falling back to a print notice. Patch attached. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien@koha-fr.org |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3304|0 |1 is obsolete| | --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-30 10:42:19 UTC --- Created attachment 4302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4302 Bug 5867 : Improved the email checking when sending "Hold filled" notices. The subroutine for sending HOLD and HOLD_PRINT notices only checked the "email" field of the borrowers table and didn't check the value of the AutoEmailPrimaryAddress preference. With this patch, "Hold filled" notices can now be sent using the other email addresses of the member. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-30 10:43:14 UTC --- Signed off patch attached -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-07-14 22:41:15 UTC --- Easy patch to read, uses existing subroutines correctly. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-14 23:11:35 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org