https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103692&action=edit Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Owen, I cannot cleanly apply this patch to master: error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt). error: could not build fake ancestor Patch failed at 0001 Bug 25276: Correct hover style of list share button in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #2)

I cannot cleanly apply this patch to master:

Sorry, I forgot to add the dependency on Bug 25211! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103692|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 103695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103695&action=edit Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25281 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25281 [Bug 25281] Use modal confirmation when deleting a list in the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103695|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103713&action=edit Bug 25276: Correct hover style of list share button in the OPAC This patch adds missing "btn" classes to the OPAC share button so that its style is consistent with similar controls. The patch also makes some general changes to the OPAC CSS to make sure link color and hover color are applied with enough specificity. This corrects the hover color of the share button but should not change any other existing style. To test you should have the OpacAllowSharingPrivateLists preference enabled. - Rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Log in to the OPAC as a user with one or more private lists. - Go to Lists -> Your lists. - In the list of lists there should be a "Share" link for each list. Hovering your mouse pointer over the link should change the style in the same way the "Edit" link does. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25276 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.