[Bug 11062] New: Invoice's shipment/shipping cost should be included PRE-gst tax (as an option)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Bug ID: 11062 Summary: Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org Here in Canada, invoices items should be included in the following order: Price Shipment Taxes Subtotal Total At least, as an option. Right now, our library gets the wrong Total since shipping is added to the subtotal, not including the taxes. I looked for preferences, but the code seemed very clear in acqui/invoice.pl: my $total_gsti_shipment = $total_est_gsti + $details->{shipmentcost}; Unless a nice solution already exists, I think this ordering should be customizable. Comments and input (on what else should be affected) are very welcomed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #1 from simith.doliveira@inlibro.com --- Created attachment 28891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28891&action=edit Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) Koha's users don't have the option to enter shipping tax. This fix allow to vendors add a specific tax (included in gist preference) to shipping cost. Modified: added two columns, shippingincgst and sgstrate in aqbooksellers. Some files changed: C4/Bookseller.pm installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl acqui/updatesupplier.pl acqui/supplier.pl acqui/parcels.pl t/db_dependent/Bookseller.t acqui/invoice.pl - total_gste_shipment and total_gsti_shipment calcul changed koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/supplier.tt - Shipping tax rate and shipping include tax or don't include tax, added koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/parcels.tt - "(tax exc.)" or "(tax inc)" added beside "Shipping cost". koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/invoice.tt - if shipping "tax exc", add "Shipping cost (tax inc)" below "Shipping cost" 0) Apply the patch 1) Run updatedatabase.pl to add the two columns to aqbooksellers 2) Add some tax rates in gist preferences 3) Edit a vendor 4) Chose shipping prices: include tax or not 5) Chose a shipping tax rate 6) Save 7) Create an order in a vendor's basket 8) click button receive shipment 9) Validate "(tax exc.)" or "(tax inc)" added beside "Shipping cost". 10) Click link "Receive order" in pending orders 11) Save 12) Click Finish receiving 13) Validate shipping "tax ex", add "Shipping cost (tax inc)" below "Shipping cost" if shipping "tax exc". 14) Validate last line "Total + Shipment cost (CDN)" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com Patch complexity|--- |Medium patch Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch against master 3.17.00.013 Applying: Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Bookseller.t Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging acqui/supplier.pl Auto-merging acqui/parcels.pl Auto-merging acqui/invoice.pl CONFLICT (content): Merge conflict in acqui/invoice.pl Failed to merge in the changes. Patch failed at 0001 Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28891|0 |1 is obsolete| | --- Comment #3 from simith.doliveira@inlibro.com --- Created attachment 31033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31033&action=edit Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) Koha's users don't have the option to enter shipping tax. This fix allow to vendors add a specific tax (included in gist preference) to shipping cost. Modified: added two columns, shippingincgst and sgstrate in aqbooksellers. Some files changed: C4/Bookseller.pm installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl acqui/updatesupplier.pl acqui/supplier.pl acqui/parcels.pl t/db_dependent/Bookseller.t acqui/invoice.pl - total_gste_shipment and total_gsti_shipment calcul changed koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/supplier.tt - Shipping tax rate and shipping include tax or don't include tax, added koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/parcels.tt - "(tax exc.)" or "(tax inc)" added beside "Shipping cost". koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/invoice.tt - if shipping "tax exc", add "Shipping cost (tax inc)" below "Shipping cost" 0) Apply the patch 1) Run updatedatabase.pl to add the two columns to aqbooksellers 2) Add some tax rates in gist preferences 3) Edit a vendor 4) Chose shipping prices: include tax or not 5) Chose a shipping tax rate 6) Save 7) Create an order in a vendor's basket 8) click button receive shipment 9) Validate "(tax exc.)" or "(tax inc)" added beside "Shipping cost". 10) Click link "Receive order" in pending orders 11) Save 12) Click Finish receiving 13) Validate shipping "tax ex", add "Shipping cost (tax inc)" below "Shipping cost" if shipping "tax exc". 14) Validate last line "Total + Shipment cost (CDN)" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- Today I've tried to apply the patch against master 3.17.00.016 There has been a conflict: Applying: Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Bookseller.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging acqui/updatesupplier.pl Auto-merging acqui/supplier.pl CONFLICT (content): Merge conflict in acqui/supplier.pl Auto-merging C4/Bookseller.pm CONFLICT (content): Merge conflict in C4/Bookseller.pm Failed to merge in the changes. Patch failed at 0001 Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #5 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- Most part of this feature is going to be implemented by the Jonathan Druart's GST refactoring work. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 We will wait his development to be upstreamed before working again on this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35994&action=edit Bug 11062: rename shipmentcost with shipping For more consistency, the shipmentcost variables and labels will be renamed with shipping. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35995&action=edit Bug 11062: Fill shipping tax excluded This patch adds the ability to enter the shipping tax excluded. Note that the total will continue to be calculated using the shipping tax included. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35996&action=edit Bug 11062: Update DB entry 3 new DB field: aqbooksellers.invoiceincgst aqbooksellers.shipping_tax_rate aqinvoices.shipping_tax_rate 1 DB field renamed aqinvoices.shipmentcost => aqinvoices.shipping -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Attachment #31033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira@inlibro.co |jonathan.druart@biblibre.co |m |m Severity|minor |enhancement Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13323 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches to apply on top of kohac/ft/bug_13323 (cf bug 13323 for more information). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org