[Bug 42779] New: Editing suggestion Fund defaults to None when field previously set.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 Bug ID: 42779 Summary: Editing suggestion Fund defaults to None when field previously set. Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: sam.sowanick@corvallisoregon.gov QA Contact: testopia@bugs.koha-community.org When editing an existing suggestion the Fund field defaults to none even if fund was previously set. This can lead to removing fund information from the suggestion if not reset by the Staff Member. Testing 1) create suggestion and set fund. Save and note fund is set in Suggestions list page. 2) edit suggestion. Note fund field is defaulted away from the previously set fund. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 --- Comment #1 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200096&action=edit Sets fund default to previous entry default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200096|0 |1 is obsolete| | --- Comment #2 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200097&action=edit Modify tt fund dropdown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200097|0 |1 is obsolete| | --- Comment #3 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200103&action=edit suggestions update fund form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 --- Comment #4 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200104&action=edit suggestions fund tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200103|0 |1 is obsolete| | --- Comment #5 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200110&action=edit Fixed formatting issuses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200104|0 |1 is obsolete| | --- Comment #6 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200111&action=edit Fixed formatting issuses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200110|0 |1 is obsolete| | --- Comment #7 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 200112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200112&action=edit suggestions fund dropdown update pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 --- Comment #8 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Test plan: 1. Create a purchase suggestion and assign it to a specific fund. 2. Edit the suggestion in the staff interface. 3. Verify that the Fund dropdown correctly displays the previously selected fund instead of defaulting to "NONE". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 --- Comment #9 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 200158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200158&action=edit Update suggestion.pl Added stored budget in budget loop Signed-off-by: Kris <kbecker@jcls.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org --- Comment #10 from Kris <kbecker@jcls.org> --- Looks good Sam, thanks for the patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please mind the QA script: Result: [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt [FAIL] suggestion/suggestion.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl suggestion/suggestion.pl` Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - b0edb5b37a0 * Commit title does not start with 'Bug XXXXX: ' - b6bc1b92b9c -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #12 from Laura O'Neil <laura@bywatersolutions.com> --- *** Bug 42768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200112|0 |1 is obsolete| | --- Comment #13 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201219&action=edit suggestions.pl with perltidy ran perltidy and fixed commit title. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200111|0 |1 is obsolete| | Status|Failed QA |Signed Off Assignee|koha-bugs@lists.koha-commun |sam.sowanick@corvallisorego |ity.org |n.gov --- Comment #14 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201220&action=edit suggestion.tt Fixed commit message to include bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42779 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Lisette Scheer <lisette@bywatersolutions.com> --- Failing QA here because the patch names are still wrong. From the Commit message page: https://wiki.koha-community.org/wiki/Commit_messages
The first line of a commit message is the subject.
It must:
Start with the bug number, formatted like "Bug XXXXX: " Provide a clear and concise description or summary of the patch
I'd also recommend squashing the suggestions.pl commits into 1 instead of a separate tidy commit. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org