[Bug 40995] New: Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Bug ID: 40995 Summary: Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If your autocomplete results include a patron without a surname, Koha still puts a comma and space between the first name and the nonexistent surname, like ", Henry." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187739&action=edit Bug 40995: Use patron_to_html in patron autocomplete So we deal with punctuation like in other places. If your autocomplete results include a patron without a surname, Koha still puts a comma and space between the first name and the nonexistent surname, like ", Henry." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 [Bug 40958] Move patron_to_html (from js-patron-format.inc) to a standalone JS file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187739|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187745&action=edit Bug 40995: Use patron_to_html in patron autocomplete So we deal with punctuation like in other places. If your autocomplete results include a patron without a surname, Koha still puts a comma and space between the first name and the nonexistent surname, like ", Henry." Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187843&action=edit Bug 40995: Add Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32176 [Bug 32176] Correctly display patrons when selected after autocomplete (was js/patron-autocomplete.js need another option) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|40958 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 [Bug 40958] Move patron_to_html (from js-patron-format.inc) to a standalone JS file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Previously the patron autocomplete results had names in inverted format (surname first). The call to patron_to_html() needs 'invert_name: true' passed to keep existing format, so that cypress tests are happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #5 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187850&action=edit Bug 40995: (follow-up) pass invert_name in patron autocomplete Passes invert_name flag to patron_to_html to restore previous format in patron autocomplete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245 [Bug 40245] Support option to display firstname in memberresultst -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187745|0 |1 is obsolete| | Attachment #187843|0 |1 is obsolete| | Attachment #187850|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188808&action=edit Bug 40995: Use patron_to_html in patron autocomplete So we deal with punctuation like in other places. If your autocomplete results include a patron without a surname, Koha still puts a comma and space between the first name and the nonexistent surname, like ", Henry." Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188809&action=edit Bug 40995: Add Cypress tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188810&action=edit Bug 40995: (follow-up) pass invert_name in patron autocomplete Passes invert_name flag to patron_to_html to restore previous format in patron autocomplete. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Pushed to main |Needs documenting --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This patch doesn’t apply cleanly to 25.05, so I’m not planning to backport it at this time. If you’re able to update it for 25.05 compatibility, I’d be happy to take another look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Bug 40995 depends on bug 32176, which changed state. Bug 32176 Summary: Correctly display patrons when selected after autocomplete (was js/patron-autocomplete.js need another option) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32176 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00, 25.05.08 released in| | --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I’ve revisited this bug and decided to backport it to 25.05.x. Thank you for your patience with the change in direction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey Laura, has backporting this to 25.05 introduced a bug with patron autocomplete? It looks like it depends on Bug 32176 which wasn't backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Aleisha Amohia from comment #12)
Hey Laura, has backporting this to 25.05 introduced a bug with patron autocomplete? It looks like it depends on Bug 32176 which wasn't backported.
Reported on the mailing list, please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Noting here as well (from my reply in Mattermost to Jonathan’s comment): I’ve attached a 25.05.x patch for Bug 32176. I’ll wait for Jonathan to review it before pushing it to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Laura Escamilla from comment #14)
Noting here as well (from my reply in Mattermost to Jonathan’s comment): I’ve attached a 25.05.x patch for Bug 32176. I’ll wait for Jonathan to review it before pushing it to the 25.05.x branch.
The suggestion is to revert this from 25.05 and I would agree that is the first step before we attempt a new aesthetic fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #15)
(In reply to Laura Escamilla from comment #14)
Noting here as well (from my reply in Mattermost to Jonathan’s comment): I’ve attached a 25.05.x patch for Bug 32176. I’ll wait for Jonathan to review it before pushing it to the 25.05.x branch.
The suggestion is to revert this from 25.05 and I would agree that is the first step before we attempt a new aesthetic fix.
A new 25.05.08-3 package is available thanks to MTJ! This excludes the patches that were breaking patron autocomplete. Those have been reverted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00, 25.05.08 |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42040 [Bug 42040] Patron autocomplete broken in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org