[Bug 17920] New: t/db_dependent/Sitemapper.t fails because of permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Bug ID: 17920 Summary: t/db_dependent/Sitemapper.t fails because of permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com The directory it attempts to create an xml file may not be writable for the user running the test. By changing the directory from the current directory to a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59060&action=edit Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions The directory it attempts to create an xml file may not be writable for the user running the test. By changing the directory from the current directory to a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad idea. TEST PLAN --------- 1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- fails 2) apply patch 3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- succeeds 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17917 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17919 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59060|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 59067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59067&action=edit Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions The directory it attempts to create an xml file may not be writable for the user running the test. By changing the directory from the current directory to a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad idea. TEST PLAN --------- 1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- fails 2) apply patch 3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- succeeds 4) run koha qa test tools Tested without qa tools Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch looks ok but I do not recreate: sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev Error: The instance doesn't exist: prove t/db_dependent/Sitemapper.t With -c: sudo koha-shell -c "prove t/db_dependent/Sitemapper.t" kohadev The tests pass, even without the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Patch looks ok but I do not recreate: sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev Error: The instance doesn't exist: prove t/db_dependent/Sitemapper.t
With -c: sudo koha-shell -c "prove t/db_dependent/Sitemapper.t" kohadev
The tests pass, even without the patch.
Depends on your permissions, but the patch is definitely an improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59067|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59157&action=edit Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions The directory it attempts to create an xml file may not be writable for the user running the test. By changing the directory from the current directory to a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad idea. TEST PLAN --------- 1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- fails 2) apply patch 3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- succeeds 4) run koha qa test tools Tested without qa tools Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Mark, Here are a few other potential candidates: t/db_dependent/SuggestionEngine_ExplodedTerms.t: my $location = File::Spec->rel2abs(dirname(__FILE__)); t/db_dependent/www/auth_values_input_www.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/batch.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/search_utf8.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/zebra_config.pl:my $source = File::Spec->rel2abs('.'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marcel de Rooy from comment #6)
Mark, Here are a few other potential candidates:
t/db_dependent/SuggestionEngine_ExplodedTerms.t: my $location = File::Spec->rel2abs(dirname(__FILE__)); t/db_dependent/www/auth_values_input_www.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/batch.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/search_utf8.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/zebra_config.pl:my $source = File::Spec->rel2abs('.');
Since you mentioned these, I'll put these on a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17934 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. Couldn't reproduce the error on kohadevbox, but patches still pass after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org