[Bug 11364] New: Label layout types and text justification types are not translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Bug ID: 11364 Summary: Label layout types and text justification types are not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Tools > Labels home > Manage label layouts > Create Label layout has two untranslatable pull-downs, a layout type one, and text justification one. The texts for those pull-downs comes from C4/Creators/Lib.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 27958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27958&action=edit Allow translating the label layout and text justification types Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types") -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Patch is Ok, but think that old legends must be removed, from C4/Creators/Lib.pm around line 129. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 36722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36722&action=edit [Follow-up] Bug 11364 - Label layout types and text justification types are not translatable Removed obsolete code from from C4/Creators/Lib.pm around line 129. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27958|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36788&action=edit Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types") Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36722|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36789&action=edit Bug 11364 - Label layout types and text justification types are not translatable Removed obsolete code from from C4/Creators/Lib.pm around line 129. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 36789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36789 Bug 11364 - Label layout types and text justification types are not translatable Review of attachment 36789: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11364&attachment=36789) ----------------------------------------------------------------- ::: C4/Creators/Lib.pm @@ -124,4 @@
{type => 'HBO', name => 'Helvetica-Bold-Oblique', selected => 0}, ];
-my $text_justification_types = [
This variable is still used. However, the name keys could be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Attachment #36789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36788|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36793&action=edit Bug 11364: Label layout types and text justification types are not translatable To test: 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgids that contain the layout types or text justification types in po/xx-YY-i-staff-t-prog-v-3006000.po 4) apply patch 5) perl translate update xx-YY 6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_label_types" and "BLOCK translate_justification_types") Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Pasi! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11364 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.9 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org