http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mjr@software.coop Version|rel_3_6 |master Change sponsored?|--- |Sponsored Assignee|paul.poulain@biblibre.com |mjr@software.coop --- Comment #1 from MJ Ray (software.coop) <mjr@software.coop> --- It would be nice to be able to see that a logged in user (or if the patron) placed or filled a reserve, wouldn't it? At first glance this can't be done in master but I think I can see how to do it (key bit is to add UpdateStats calls to C4::Reserves). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 --- Comment #2 from MJ Ray (software.coop) <mjr@software.coop> --- Created attachment 8945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8945&action=edit C4/Reserves.pm: log reservation actions catalogue/issuehistory.tt: link to viewlog for circulation log tools/viewlog.tt: add HOLD and UNHOLD actions, move results table nearer top tools/viewlog.pl: be more cautious in assuming info field in CIRCULATION is -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt :( I was looking forward to this too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 --- Comment #6 from MJ Ray (software.coop) <mjr@software.coop> --- It blooming well did after I rebased on 2012-12-14 :-( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14109|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21817&action=edit Bug 6890 - log reservation actions C4/Reserves.pm: log reservation actions catalogue/issuehistory.tt: link to viewlog for circulation log tools/viewlog.tt: add HOLD and UNHOLD actions, move results table nearer top tools/viewlog.tt: rewrite to use loopro.module and to link better members/readingrec.tt: link to circulation log for hold/unhold info To test: 1. place a few holds and release them somehow (cancel or issue); 2. view the reading record of an affected borrower; 3. click the link to the modification log and see the holds; 4. click the link to an affected biblio; 5. click to view its circulation history; 6. click the link to the modification log and see the holds. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- The logs should be written only if a pref is set. It is the usual way to log actions into Koha. Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to MJ Ray (software.coop) from comment #10)

In reply to comment 9:

...

The logs should be written only if a pref is set. It is the usual way to log actions into Koha.

What pref should be set?

What coding guideline sets this out?

Hello MJ, You can have a look at admin/preferences.pl?tab=logs and at the result of the following command: git grep logaction The action_logs table is filled depending on syspref values, so I suppose you should do the same. If you disagree, you can ask another QAer to have a look. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.