[Bug 9314] New: Messaging preferences not updated to category defaults on patron edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Bug ID: 9314 Summary: Messaging preferences not updated to category defaults on patron edit Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: rolando.isidoro@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On the patron edit form, under the "Patron messaging preferences" there's a message stating: "If no preferences are selected, the default preferences for the category chosen will be applied on save, otherwise your selection here is saved" When no preferences are selected the default preferences for the chose category are not being applied on save. As an enhancement a button could be added to reset the messaging preferences to default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Note that the message appears in a couple of situations: On patron edit, or on patron creation *if* you have your AddPatronLists preference set to "category_type." Looking at the code it looks like the message is intended to appear only upon patron add if AddPatronLists is set to "category_type." The warning is required because in that situation the patron category is not yet known. Therefore the interface reminds the user that default messaging preferences will be applied if none are chosen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Since I suggested to remove the broken pref AddPatronLists in bug 13497, I think the better would be to simply remove the message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13497 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Version|3.8 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37577&action=edit Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13497 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13970 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #4 from Rolando Isidoro <rolando.isidoro@gmail.com> --- Jonathan, following your comments I can confirm that the information message is no longer displayed so this bug report is deprecated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rolando, without the path I submitted on comment 3, the message can longer appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37577|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39314&action=edit [SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Dead code removed, no errors Think that bug description can be updated to commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Messaging preferences not |Remove useless code related |updated to category |to the type_only parameter |defaults on patron edit | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39314|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39957&action=edit [PASSED QA] Bug 9314: Remove useless code related to the type_only parameter Since the pref AddPatronLists has been removed in bug 13497, the code related to type_only and category_type in memberentry.pl is useless. Test plan: Confirm you don't the information message. You can also confirm that the message was wrong and nothing was saved. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Dead code removed, no errors Think that bug description can be updated to commit message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 (shouldn't be needed for other branches) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org