[Bug 37031] New: Club enrollment doesn't complete in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Bug ID: 37031 Summary: Club enrollment doesn't complete in staff client Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you enroll a user into a club from the issues tab on a user record, it never completes. This is due to a typo in line 64 of /usr/share/koha/intranet/cgi-bin/svc/club/enroll which says my $already_enrolled = Koha::Club::Entrollments->search( Changing this line to my $already_enrolled = Koha::Club::Enrollments->search( seems to fix the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Summary|Club enrollment doesn't |Club enrollment doesn't |complete in staff client |complete in staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Bug 35942 is missing from main so this fix can't currently be implemented -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35942 CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- It's on main now. For extra fun, the backport patch for 23.05 didn't have this typo, so it currently affects 24.11, 23.11, and 24.05 once the offending patch gets backported there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35942 [Bug 35942] OPAC user can enroll several times to the same club -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 168573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168573&action=edit Bug 37031: Club enrollment from staff interface fails due to Entrollment typo Having svc/club/enroll try to call Koha::Club::Entrollments->search would have been great trolling, if only it had been intentional and if only any of the people signing off had noticed it. Test plan: 1. Without the patch, Tools - Patron clubs - New club template - name it and save 2. New club - (your template) - name it and save 3. Circulation - check out to a patron - Clubs tab - Enroll - Finish enrollment, get alert() about failure to enroll 4. Apply patch, restart_all 5. Enroll - Finish enrollment, success -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168573|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 168643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168643&action=edit Bug 37031: Club enrollment from staff interface fails due to Entrollment typo There is a typo in svc/club/enroll - it tries to call Koha::Club::Entrollments->search when it should be Koha::Club::Enrollments. This causes and error when enrolling patrons in clubs. Test plan: 1. Without the patch, Tools - Patron clubs - New club template - name it and save 2. New club - (your template) - name it and save 3. Circulation - check out to a patron - Clubs tab - Enroll - Finish enrollment, get alert() about failure to enroll 4. Apply patch, restart_all 5. Enroll - Finish enrollment, success Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes a typo in the release notes| |code that causes the | |enrollment of a patron in a | |club to fail. --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Phil for fixing! Note: I updated the description for the bug commit message. I'm not sure that the previous description should be in the git history - we all make mistakes from time to time, either in testing or QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168643|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 168745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168745&action=edit Bug 37031: Club enrollment from staff interface fails due to Entrollment typo There is a typo in svc/club/enroll - it tries to call Koha::Club::Entrollments->search when it should be Koha::Club::Enrollments. This causes and error when enrolling patrons in clubs. Test plan: 1. Without the patch, Tools - Patron clubs - New club template - name it and save 2. New club - (your template) - name it and save 3. Circulation - check out to a patron - Clubs tab - Enroll - Finish enrollment, get alert() about failure to enroll 4. Apply patch, restart_all 5. Enroll - Finish enrollment, success Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate, | |rel_22_11_candidate, | |rel_23_05_candidate, | |rel_23_11_candidate, | |rel_24_05_candidate CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate, | |rel_22_11_candidate, | |rel_23_05_candidate | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- It's only on 24.05 (once it gets bug 35942) and 23.11 because 23.05 and below got a patch without the typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Phil Ringnalda from comment #7)
It's only on 24.05 (once it gets bug 35942) and 23.11 because 23.05 and below got a patch without the typo.
That's good news! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Merge conflicts here, please rebase for 24.05.x if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- I don't get any conflicts applying it on 24.05.x, now that you've got bug 35942 - did you try to apply this one before that one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable Keywords|rel_24_05_candidate | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 There are no other typos :
git grep Entrollment => empty
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from wainuiwitikapark@catalyst.net.nz --- Is this needed for 23.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- No, the typo didn't make it back past 23.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37031 Bug 37031 depends on bug 35942, which changed state. Bug 35942 Summary: OPAC user can enroll several times to the same club https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35942 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org