https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Srdjan Jankovic from comment #47)

Created attachment 55578 [details] [review] bug_15562: Removed Koha::Caches->get_instance()

There should be no cache singletons, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Caches->get_instance() is replaced with C4::Context->cache. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context.

Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached.

Did you notice that Koha::Caches->get_instance could take a subnamespace parameter? Currently we have 3 different subnamespaces: the default one (""), syspref and config. Just looking at the code, I'd say it introduces a regressions: if the memcached configuration (defined in koha-conf.xml) is different than the default one (localhost:11211) it won't be used. -- You are receiving this mail because: You are watching all bug changes.