[Bug 36774] New: Flatpickr clear() adds unintentional clear button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Bug ID: 36774 Summary: Flatpickr clear() adds unintentional clear button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166138&action=edit Bug 36774: [DONT PUSH] TEST ONLY Test plan: 1) Apply only the TEST patch 2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 3) Click the "Expires before" input and insert any date 4) Click the "TEST" link under. It calls the native flatpickr.clear(): https://flatpickr.js.org/instance-methods-properties-elements/#clear 5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. 6) Apply 2nd patch. Repeat. Notice it works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166139&action=edit Bug 36774: Dont add wrapper if already exists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34263 [Bug 34263] Suspending holds consecutively populates previously used date falsely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Context at bug 34263 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- There is also calendar.inc at opac-tmpl/bootstrap/en/includes/calendar.inc and this change further diverges both files. It's a dupe of this file but for the OPAC (see bug 35716 if you're interested in this topic i.e. stop duping assets for OPAC+INTRA) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35716 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166138|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 166162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166162&action=edit Bug 36774: [DONT PUSH] TEST ONLY Test plan: 1) Apply only the TEST patch 2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 3) Click the "Expires before" input and insert any date 4) Click the "TEST" link under. It calls the native flatpickr.clear(): https://flatpickr.js.org/instance-methods-properties-elements/#clear 5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. 6) Apply 2nd patch. Repeat. Notice it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166139|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 166163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166163&action=edit Bug 36774: Dont add wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m --- Comment #7 from David Nind <david@davidnind.com> --- Added assignee -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Bug 30718: Prevent 'reset' icon to appear twice - $(instance.input).siblings('input.flatpickr') + $(instance.input).find('~input.flatpickr:first') Maybe we need to adjust this line as well then because it was supposed to deal with that problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #8)
Bug 30718: Prevent 'reset' icon to appear twice
- $(instance.input).siblings('input.flatpickr') + $(instance.input).find('~input.flatpickr:first')
Maybe we need to adjust this line as well then because it was supposed to deal with that problem.
I don't know. From my testing, that change from bug 30718 didn't fix the problem it said it fixed, i.e. the problem is there before and after that change. However, reverting it back to the previous code makes the "x" button stop working, it doesn't clear anymore. I don't have more time to dig deeper here but unless we come up with a test plan highlighting why we need to adjust that line I'd say it's a non-issue imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- I guess it was supposed to fix this:
From bug 30718 comment 22 """ I notice also that paired date fields (start date & end date) now show an extra "X" icon after the second field, e.g. serial claims or catalog statistics. """
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #10)
I guess it was supposed to fix this:
From bug 30718 comment 22 """ I notice also that paired date fields (start date & end date) now show an extra "X" icon after the second field, e.g. serial claims or catalog statistics. """
Tested both entries of the JS line below on the ILL requests page (there are 4 flatpickr instances on the left side filters):
- $(instance.input).siblings('input.flatpickr') + $(instance.input).find('~input.flatpickr:first')
I couldn't spot any difference before and after. Mind you I didn't test the clear itself because those filters 'clear' functionality needs to be updated, but the rendering of the inputs is fine, no additional "x" anywhere are rendered. Also looked at /tools/holidays.pl but can't find any issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- On main, if I revert commit 97a4b3c61da522f35628f80382d21bbff56b76ba Bug 30718: Prevent 'reset' icon to appear twice I am seeing: https://snipboard.io/XLKMVg.jpg on /cgi-bin/koha/serials/claims.pl?supplierid=1 KO (2 clears for "to") On main, I am seeing: https://snipboard.io/u728qI.jpg OK 1 clear for "from", 1 for "to" On main + your patch: https://snipboard.io/6BusJT.jpg KO 1 clear for "from" but no clear for "to" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166278&action=edit Bug 36774: Ensure we are looking for a parent with the given class And not one of its children -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- I think you want that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166278|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Comment on attachment 166278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166278 Bug 36774: Ensure we are looking for a parent with the given class Hi Joubu, thank you very much for the follow-up, it fixes the claims page issue but it causes my test plan to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166162|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166303&action=edit Bug 36774: [DONT PUSH] TEST ONLY Test plan: 1) Apply only the TEST patch 2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 3) Click the "Expires before" input and insert any date 4) Click the "TEST" link under. It calls the native flatpickr.clear(): https://flatpickr.js.org/instance-methods-properties-elements/#clear 5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. 6) Apply 2nd patch. Repeat. Notice it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166163|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166304&action=edit Bug 36774: Dont add wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166305&action=edit Bug 36774: (QA Follow-up): Use flatpickr clear Im not sure why, but with the way it was before, there was a bug in my test plan. If you cleared using the TEST link, and then input some date and clear with the 'x', a JS error would occurr. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36804 [Bug 36804] Serials claims 'Clear filter' doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #12)
On main, if I revert commit 97a4b3c61da522f35628f80382d21bbff56b76ba Bug 30718: Prevent 'reset' icon to appear twice
I am seeing: https://snipboard.io/XLKMVg.jpg on /cgi-bin/koha/serials/claims.pl?supplierid=1 KO (2 clears for "to")
On main, I am seeing: https://snipboard.io/u728qI.jpg OK 1 clear for "from", 1 for "to"
On main + your patch: https://snipboard.io/6BusJT.jpg KO 1 clear for "from" but no clear for "to"
Thanks for this. I've submitted a squashed follow-up to the original patch and a follow-up to fix a bug I discovered while re-testing this, explanation in the commit message. I had a hard time following your claims use case, but in the end I was able to and I think I discovered a bug in it as well. Filed bug 36804. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166303|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 166383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166383&action=edit Bug 36774: [DONT PUSH] TEST ONLY Test plan: 1) Apply only the TEST patch 2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 3) Click the "Expires before" input and insert any date 4) Click the "TEST" link under. It calls the native flatpickr.clear(): https://flatpickr.js.org/instance-methods-properties-elements/#clear 5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. 6) Apply 2nd patch. Repeat. Notice it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166304|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 166384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166384&action=edit Bug 36774: Dont add wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166305|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 166385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166385&action=edit Bug 36774: (QA Follow-up): Use flatpickr clear Im not sure why, but with the way it was before, there was a bug in my test plan. If you cleared using the TEST link, and then input some date and clear with the 'x', a JS error would occurr. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36804 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36804 [Bug 36804] Serials claims 'Clear filter' doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36804 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36804 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36804 [Bug 36804] Serials claims 'Clear filter' doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166384|0 |1 is obsolete| | Attachment #166385|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166395&action=edit Bug 36774: Dont add wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166396&action=edit Bug 36774: (QA Follow-up): Use flatpickr clear Im not sure why, but with the way it was before, there was a bug in my test plan. If you cleared using the TEST link, and then input some date and clear with the 'x', a JS error would occurr. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- It would be nice to have a cypress test for this, but not considering blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- There's a flaw in my code. It's changing the css class to flatpickr_wrapper_(id of the element), thus causing CSS rules to flatpickr_wrapper to not apply. See issues caused at <staff_url>/cgi-bin/koha/circ/overdue.pl I opted for this approach intentionally in case the flatpickr input does not contain an id, but it's not great, need to revisit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166383|0 |1 is obsolete| | --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166423&action=edit Bug 36774: [DONT PUSH] TEST ONLY Test plan: 1) Apply only the TEST patch 2) Visit http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 3) Click the "Expires before" input and insert any date 4) Click the "TEST" link under. It calls the native flatpickr.clear(): https://flatpickr.js.org/instance-methods-properties-elements/#clear 5) Notice it clears the date value. But it also appends a new 'x' icon to clear the input. 6) Apply 2nd patch. Repeat. Notice it works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166424&action=edit Bug 36774: Remove wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166425&action=edit Bug 36774: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166425|0 |1 is obsolete| | --- Comment #30 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166427&action=edit Bug 36774: Add cypress tests Inside k-t-d, run: cypress run --spec t/cypress/integration/flatpickr_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pedro Amorim from comment #18)
Created attachment 166305 [details] [review] Bug 36774: (QA Follow-up): Use flatpickr clear
Im not sure why, but with the way it was before, there was a bug in my test plan. If you cleared using the TEST link, and then input some date and clear with the 'x', a JS error would occurr.
I now know why, flatpickr().clear() is re-adding the 2nd input and triggering onReady but because onReady was returning early it was not re-wrapping the flatpickr_wrapper, causing this error. In hindsight, I don't think we should be adding this clear button on onReady but use wrap from flatpickr instead: https://flatpickr.js.org/examples/#flatpickr-external-elements But I've invested enough time here and this is too much work for little gain. Joubu, David, apologies for the back and forth here, this turned out to be a much deeper rabbit hole than I thought. I've added cypress tests (more tests on the claims page and patron hold tab could be added though) and went through the test plans in bug 34263 and bug 36804 again to make sure everything is working as expected, I believe it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166424|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166463&action=edit Bug 36774: Remove wrapper if already exists Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166427|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166464&action=edit Bug 36774: Add cypress tests Inside k-t-d, run: cypress run --spec t/cypress/integration/flatpickr_spec.ts Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #36 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #37 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36774 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #38 from David Nind <david@davidnind.com> --- No updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org