[Bug 4812] New: Reserves for a specific copy of a book say book is available even though it it still checked out to someone else
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Summary: Reserves for a specific copy of a book say book is available even though it it still checked out to someone else Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Hold requests AssignedTo: gmcharlt@gmail.com ReportedBy: kyle.m.hall@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When you place a reserve on a specific copy of a book a note is immediately put on the card of the person for whom the book is being reserved that says the book is available even though it is still checked out to someone else. The code is in placerequest.pl # if we have an item selectionned, and the pickup branch is the same as the holdingbranch # of the document, we force the value $rank and $found . if ($checkitem ne ''){ $rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns'); my $item = $checkitem; $item = GetItem($item); if ( $item->{'holdingbranch'} eq $branch ){ $found = 'W' unless C4::Context->preference('ReservesNeedReturns'); } } This code does not bother to check to see if an item is actually on the shelf, it sets it to 'W' reguardless. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Same problem may effect item-level requests placed via C4/ILSDI/Services.pm and opac/opac-reserve.pl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 2172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2172 Intranet Holds Bugfix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2172|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 2173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2173 Bugfix for both intranet & opac holds. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |magnus@enger.priv.no Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-19 15:54:12 UTC --- I was able to reproduce the problem. I tried testing the patch: 1) activate sys pref Reserveneedsreturn 2) checkout item (patron 1 from library A, item from library A) 3) item level hold for patron 2 (also from library A) 4) item shows as pending in OPAC -ok 5) item shows as "Item being transferred to" title's holds page (?) I am not sure if 5) is a problem with my configuration. Can someone else test? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-03-29 14:48:15 UTC --- Created attachment 3500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3500 Screenshot of holds list after patch was applied I was able to reproduce this bug with ReservesNeedReturns set to "Automatically mark holds as found and waiting..." After applying the patch and following the same procedure cait describes I saw the attached screen. An incomplete "Item being transferred to" under "Pickup library" and "No barcode" under details, although the hold was for a specific copy. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is this still an issue? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- We have this problem for one of your libraries. It is a real bug for me, not an enhancement. By the way, I think the mean of ReservesNeedReturns is wrong, it generates several bugs when inactive : - this bug - you can place a waiting reserve when there is already a waiting reserve - you do not have messages present is return page In my opinion, reserves module is too weak to repair, this syspref should be removed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812 Pongtawat <pongtawat@punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat@punsarn.asia --- Comment #8 from Pongtawat <pongtawat@punsarn.asia> --- I found this is still a problem in Koha 3.12 Step to reproduce: 1) activate sys pref ReservesNeedReturns 2) patron 1 checkout item A 3) patron 2 place an item-specific hold for item A to be deliver at its current location 4) item A shows as "Checked out to 1" and "Waiting for 2" at the same time. (Intranet) The code appears to still be the same as in Kyle M Hall's original comment. If ReservesNeedReturns is off, it will just mark item as waiting for pick up. Moreover, I found that this preference descriptive text quite confusing: to turn ReservesNeedReturns on, I have to choose "Don't automatically mark holds ...". I would expect something like "Do" to mean on and "Don't" to mean off. Maybe just my silliness anyway :P -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org