[Bug 37551] New: MarcFieldsToOrder price is overriding MarcItemFieldsToOrderPrice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Bug ID: 37551 Summary: MarcFieldsToOrder price is overriding MarcItemFieldsToOrderPrice Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In the code: # Price is handled as "itemprice" in the UI form to distinguish from MarcFieldsToOrder $iteminfos->{itemprice} = delete $iteminfos->{price} if $iteminfos->{price}; and later $iteminfos->{price} ||= $price; # Fallback to order price if no item price was defined Well, this means we will always fallback, because we deleted it. itemprice is the variable name when processing the form, but for populating we use 'price' I touched all of these lines, so I am blamed, but seems a clear mistake -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Main |24.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- This seems to resolved in main by Bug 35026. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170735&action=edit Marc file for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- To recreate: 1. Have a mrc file with some different prices. In my case I am using the mrc file attached here with different price values in the 975$p and 975$a 2. Set the MarcFieldsToOrder to "price: 975$p" and MarcItemFieldsToOrder to "price: 975$a" 3. In Acquisitions create a new basket > add to basket > from a new file 4. The value from MarcFieldsToOrder (975$p) is always set as the price when it should be the value from MarcItemFieldsToOrder (975$a) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170736&action=edit Bug 37551: Only delete price when there is already an itemprice To test: 1. Have a mrc file with some different prices. In my case I am using the mrc file attached here with different price values in the 975$p and 975$a 2. Set the MarcFieldsToOrder to "price: 975$p" and MarcItemFieldsToOrder to "price: 975$a" 3. In Acquisitions create a new basket > add to basket > from a new file 4. The value from MarcFieldsToOrder (975$p) is always set as the price when it should be the value from MarcItemFieldsToOrder (975$a) 5. APPLY PATCH, restart_all 6. Try steps 1 - 3 again, this time item price should be correctly handled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170736|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170737&action=edit Bug 37551: (24.05.x) Only delete price when there is already an itemprice To test: 1. Have a mrc file with some different prices. In my case I am using the mrc file attached here with different price values in the 975$p and 975$a 2. Set the MarcFieldsToOrder to "price: 975$p" and MarcItemFieldsToOrder to "price: 975$a" 3. In Acquisitions create a new basket > add to basket > from a new file 4. The value from MarcFieldsToOrder (975$p) is always set as the price when it should be the value from MarcItemFieldsToOrder (975$a) 5. APPLY PATCH, restart_all 6. Try steps 1 - 3 again, this time item price should be correctly handled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- While Bug 35026 I don't think we'll want to backport all of that to 24.05? So I made a patch for 24.05.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com Status|Needs Signoff |Signed Off --- Comment #7 from Donna <bwsdonna@gmail.com> --- Tested, works as expected. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170737|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171627&action=edit Bug 37551: (24.05.x) Only delete price when there is already an itemprice To test: 1. Have a mrc file with some different prices. In my case I am using the mrc file attached here with different price values in the 975$p and 975$a 2. Set the MarcFieldsToOrder to "price: 975$p" and MarcItemFieldsToOrder to "price: 975$a" 3. In Acquisitions create a new basket > add to basket > from a new file 4. The value from MarcFieldsToOrder (975$p) is always set as the price when it should be the value from MarcItemFieldsToOrder (975$a) 5. APPLY PATCH, restart_all 6. Try steps 1 - 3 again, this time item price should be correctly handled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.04 released in| | Keywords|rel_24_05_candidate | Status|Passed QA |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33171 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33171 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37551 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Bug fix, doesn't need to be documented. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org