[Bug 20761] New: Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Bug ID: 20761 Summary: Advanced Cataloging Editor - Rancor - Some js files are not fetched using Asset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 75292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75292&action=edit Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75292|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75613&action=edit Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20538 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That's odd, how did we miss these ones?? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 [Bug 20538] Remove the need of writing [% KOHA_VERSION %] everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75613|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 75619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75619&action=edit Bug 20761: Fix some js includes in rancor To test: 1 - Load the advanced cataloging editor 2 - Inspect the network tab in your browser (F12) 3 - Note failure to load 'cataloging_.js' 4 - Note some other scripts don't have versioning 5 - Apply patch 6 - Reload page 7 - Note cataloging.js loads with version number 8 - Note more js files have versioning Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master QA Contact|testopia@bugs.koha-communit |chris@bigballofwax.co.nz |y.org | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20761 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 20538 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org