[Bug 35352] New: Cannot hide SMSalertnumber via BorrowerUnwantedField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Bug ID: 35352 Summary: Cannot hide SMSalertnumber via BorrowerUnwantedField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159054&action=edit Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159054|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159068&action=edit Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This works as described. With the patch applied, the SMS Number field still shows up under the messaging pref box on moremember.pl. It kinda feels like setting it in BorrowerUnwanted should also hide it on moremember.pl. Also, I just filed bug 35356 to suggest we not show SMS Number on moremember.pl at all if the patron doesn't have a value for that in their record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159068|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159074&action=edit Bug 35352: Allow SMSalertnumber to be hidden via BorrowerUnwantedField To test: 1. Add a value to SMSSendDriver like 'Emial'. 2. Go to BorrowerUnwantedField and attempt to hide "Mobile phone number (smsalertnumber)" 3. Go to members/memberentry.pl and see the field is not hidden. 4. APPLY PATCH 5. Try step 3 again and this time the field should be properly hidden. Note: This patch also includes some indentation changes. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Andrew Fuerste-Henry from comment #3)
With the patch applied, the SMS Number field still shows up under the messaging pref box on moremember.pl. It kinda feels like setting it in BorrowerUnwanted should also hide it on moremember.pl. Also, I just filed bug 35356 to suggest we not show SMS Number on moremember.pl at all if the patron doesn't have a value for that in their record.
Good observation thanks for the new ticket :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.01 |24.05.00,23.11.01,23.05.07 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org