[Bug 33316] New: Improve display of ES indexer jobs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Bug ID: 33316 Summary: Improve display of ES indexer jobs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148570&action=edit Bug 33316: Improve display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32594 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- This could certainly be improved, but is better than it was To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: 1. I used 'Batch item modification' to add a public note to two items. 2. Repeated step 1, but added a non-public note for the same items. 3. List of jobs shows 4 jobs - 2 for batch item modifications, and 2 for Elasticsearch index updates. 4. When viewing the details for an Elastic search index update, it now lists the record ids updated in the detailed messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148570|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 148576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148576&action=edit Bug 33316: Improve display Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This should depend on the decision of keeping or removing Koha::BackgroundJob::UpdateElasticIndex->process (see bug 32594 comment 41 & 43). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please make sure commit message has a descriptive subject and includes test plan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148576|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149394&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed the test, but I have a problem with the indexing job - it doesn't get done, so I can't verify the display. I remain stuck with: 3 New null/1 Update Elasticsearch index 04/10/2023 16:25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149394|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149395&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149396&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
I've fixed the test, but I have a problem with the indexing job - it doesn't get done, so I can't verify the display. I remain stuck with:
3 New null/1 Update Elasticsearch index 04/10/2023 16:25
Turns out, things work better when Elastisearch is actually running... (In reply to Jonathan Druart from comment #5)
This should depend on the decision of keeping or removing Koha::BackgroundJob::UpdateElasticIndex->process (see bug 32594 comment 41 & 43).
I am not sure about this one. Bug 32594 is now pushed to master, the job is still there. I think this won't hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149396|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149397&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment 5 still valid. Nick? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
Comment 5 still valid. Nick?
I am happy either way - if you want to remove 'process', please file a bug :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sorry, I don't have time for this now. Back to PQA, but we should not push as it IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #15)
Sorry, I don't have time for this now.
Back to PQA, but we should not push as it IMO.
This is only a display change - can you explain your worries? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149395|0 |1 is obsolete| | Attachment #149397|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149585&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149586&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #16)
(In reply to Jonathan Druart from comment #15)
Sorry, I don't have time for this now.
Back to PQA, but we should not push as it IMO.
This is only a display change - can you explain your worries?
Not better than on bug 32594 comment 41. This is all good now. Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Bug 33316 depends on bug 33486, which changed state. Bug 33486 Summary: Remove Koha::BackgroundJob::UpdateElasticIndex->process routine https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to stable --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Backport requested - simple change, happy to backport. Resetting bug and backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00 |23.05.00,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org