https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158111&action=edit Bug 35193: Rename "Message subject" to "File name" when module "Reports" was chosen Test Plan: 1) Apply this patch 2) Restart all the things! 3) Choose to make or edit a reports notice/slip 4) Note the "Message subject" label has been replaced with "File name" for new and existing reports notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158111|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158375&action=edit Bug 35193: Rename "Message subject" to "File name" when module "Reports" was chosen This changes the form for adding new notices so the "Message subject" is labelled as "File name" when the Reports module was chosen. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Choose to make or edit a reports notice/slip 4) Note the "Message subject" label has been replaced with "File name" for new and existing reports notices Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #4)

(In reply to Katrin Fischer from comment #3)

...

I think this is a good improvement, but I see a problem I hadn't thought of before: when editing or creating a new notice/slip, you can change the module on top and then the labels are not changing with it.

Should we add the JS to achieve this?

I just tested on master and when I change the module at the top the page reloads and updates the language just as you describe!

@katrin can you re-check? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Bug 34136 states that the template needs to be added to the "Print" area, but testing this, this patch is also changing for the "E-mail" and "SMS" areas, it seems unintended. (In reply to Kyle M Hall from comment #4)

(In reply to Katrin Fischer from comment #3)

...

I think this is a good improvement, but I see a problem I hadn't thought of before: when editing or creating a new notice/slip, you can change the module on top and then the labels are not changing with it.

Should we add the JS to achieve this?

I just tested on master and when I change the module at the top the page reloads and updates the language just as you describe!

Labels are changing for me correctly when changing the module on top. I can't reproduce what Katrin describes here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is very odd, but the page doesn't reload for me :( Maybe I found the difference: * Edit an existing notice * Change the module on top * Verify page isn't reloaded, labels don't change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158795&action=edit Bug 35193: Reload page on notice edit when switching Koha module Test plan, k-t-d: 1) Edit an existing notice, e.g.: /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=report&code=ACCOUNTS_SUMMARY 2) Change the Koha module dropdown value 3) Notice the page doesnt refresh 4) Apply patch. Repeat. Notice it refreshes now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- String freeze already. We can fix this after the release. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158795|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158815&action=edit Bug 35193: Reload page on notice edit when switching Koha module Test plan, k-t-d: 1) Edit an existing notice, e.g.: /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=report&code=ACCOUNTS_SUMMARY 2) Change the Koha module dropdown value 3) Notice the page doesnt refresh 4) Apply patch. Repeat. Notice it refreshes now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Pedro Amorim from comment #7)

Bug 34136 states that the template needs to be added to the "Print" area, but testing this, this patch is also changing for the "E-mail" and "SMS" areas, it seems unintended.

I'm ready to SO but can we confirm if the above is intended? It seems off that a "E-mail" or "SMS" section would be labeled as "File name" instead of "Message subject" I can sort of see it making sense for "Print" as we're downloading the "Print" render of the notice template, and I haven't thought about this long enough, but wouldn't a new distinct "File" section be more appropriate for this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #16)

(In reply to Pedro Amorim from comment #7)

...

Bug 34136 states that the template needs to be added to the "Print" area, but testing this, this patch is also changing for the "E-mail" and "SMS" areas, it seems unintended.

I'm ready to SO but can we confirm if the above is intended? It seems off that a "E-mail" or "SMS" section would be labeled as "File name" instead of "Message subject"

I can sort of see it making sense for "Print" as we're downloading the "Print" render of the notice template, and I haven't thought about this long enough, but wouldn't a new distinct "File" section be more appropriate for this?

The intention of the feature is to only use the "print" transport. I've added a followup so that only the print transport shows up for report notice templates. I think that solves the issue nicely! If you sign it, we can use Katrin's sign-off as the QA signoff at her discretion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158815|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158882&action=edit Bug 35193: Reload page on notice edit when switching Koha module Test plan, k-t-d: 1) Edit an existing notice, e.g.: /cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=report&code=ACCOUNTS_SUMMARY 2) Change the Koha module dropdown value 3) Notice the page doesnt refresh 4) Apply patch. Repeat. Notice it refreshes now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158884&action=edit Bug 35193: (QA follow-up): Add missing opening div panel Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I've added my sign-off, if @Katrin wants to turn hers to PQA. (In reply to Kyle M Hall from comment #18)

The intention of the feature is to only use the "print" transport. I've added a followup so that only the print transport shows up for report notice templates. I think that solves the issue nicely! If you sign it, we can use Katrin's sign-off as the QA signoff at her discretion.

I think it solves the issue nicely! However, previously we could have an "E-mail" type of notice for a Report and now we don't! I have added a new follow-up that maintains the "Email" and "SMS" options and only shows "File name" for "Print", keeping "Message subject" for the other two. Feel free to obsolete if this is not needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #25)

(In reply to Pedro Amorim from comment #24)

...

I think it solves the issue nicely! However, previously we could have an "E-mail" type of notice for a Report and now we don't! I have added a new follow-up that maintains the "Email" and "SMS" options and only shows "File name" for "Print", keeping "Message subject" for the other two. Feel free to obsolete if this is not needed.

I'm not opposed to that, but I'm curious how you would use the email and sms options.

This is why I said feel free to obsolete =D I don't know the feature in-depth but I would imagine you would also be able to send a report notice to an e-mail (as with other notices types), additionally to have the option to download it, if not please ignore it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #26)

(In reply to Kyle M Hall from comment #25)

...

(In reply to Pedro Amorim from comment #24)

...

I think it solves the issue nicely! However, previously we could have an "E-mail" type of notice for a Report and now we don't! I have added a new follow-up that maintains the "Email" and "SMS" options and only shows "File name" for "Print", keeping "Message subject" for the other two. Feel free to obsolete if this is not needed.

I'm not opposed to that, but I'm curious how you would use the email and sms options.

This is why I said feel free to obsolete =D I don't know the feature in-depth but I would imagine you would also be able to send a report notice to an e-mail (as with other notices types), additionally to have the option to download it, if not please ignore it.

Thanks! I'm going to deprecate it for the time being because that is not a function the feature supports at this time, though it would make for a great followup enhancement! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #28)

I agree, I think showing only the option that works is better for now. I'll try to test, but feel free to beat me to it :)

Hey, I have tested and signed-off =D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #30)

(In reply to Pedro Amorim from comment #29)

...

(In reply to Katrin Fischer from comment #28)

...

I agree, I think showing only the option that works is better for now. I'll try to test, but feel free to beat me to it :)

Hey, I have tested and signed-off =D

I meant don't wait up for me with QA, but I'll try to come back to this next chance I get.

I believe I didn't wait for the page reload, should be an easy QA now :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35193 Bug 35193 depends on bug 34456, which changed state. Bug 34456 Summary: Add the ability to download a template rendered report as a file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.