[Bug 30042] New: Remove Date::Calc use in cleanborrowers.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Bug ID: 30042 Summary: Remove Date::Calc use in cleanborrowers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29843 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is no occurrence of Date::Calc in tools/cleanborrowers.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove Date::Calc use in |Remove Date::Calc use in |cleanborrowers.pl |batch_anonymize.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 130334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130334&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #1)
There is no occurrence of Date::Calc in tools/cleanborrowers.pl
Right, sorry for that. I read 'the cronjob' on bug 29843 and jumped to file this one so we don't forget, but didn't check if the file was the right one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why this script and not all other occurrences then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove Date::Calc use in |Remove Date::Calc use |batch_anonymize.pl | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Bug 30042 depends on bug 29843, which changed state. Bug 29843 Summary: Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I still think this should be moved forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala@iki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- After the patch we add days instead of subtracting them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130334|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140015&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Joonas Kylmälä from comment #6)
After the patch we add days instead of subtracting them.
How did that happen LOL. Fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140015|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140016&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140016|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140175&action=edit Bug 30042: Remove Date::Calc dependency in batch_anonymize.pl This patch makes the script use the Koha::DateUtils tools instead. To test: 1. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --verbose --days 7 => SUCCESS: You see (the date may vary): Checkouts and holds before 2022-02-15 will be anonymised. 2. Apply this patch 3. Repeat 1 => SUCCESS: Same output 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |RESOLVED --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on bz29843, can't backport to 21.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30042 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)
Why this script and not all other occurrences then?
Yes, the title of this report is misleading.. git grep -l Date::Calc | wc -l 41 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org