https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62369|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 62554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62554&action=edit Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055. This will cause all messages that come after the error to not be sent! Test Plan: 1) Enable SMS via Email 2) Enable SMS for a patron, but don't set a provider 3) Perform an action that will trigger an sms message to go into the holds queue ( item due, item checkout, etc ) 4) Run process_message_queue.pl, note the error 5) Apply the patch 4) Run process_message_queue.pl, no error this time! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62554|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 62580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62580&action=edit Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055. This will cause all messages that come after the error to not be sent! Test Plan: 1) Enable SMS via Email 2) Enable SMS for a patron, but don't set a provider 3) Perform an action that will trigger an sms message to go into the holds queue ( item due, item checkout, etc ) 4) Run process_message_queue.pl, note the error 5) Apply the patch 4) Run process_message_queue.pl, no error this time! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62580|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62619&action=edit Bug 18457 - process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron If SMS via Email is enabled, and a patron has opted for SMS messages, but has not selected a service provider, the cronjob will die with the error Can't call method "domain" on an undefined value at /usr/share/koha/lib/C4/Letters.pm line 1055. This will cause all messages that come after the error to not be sent! Test Plan: 1) Enable SMS via Email 2) Enable SMS for a patron, but don't set a provider 3) Perform an action that will trigger an sms message to go into the holds queue ( item due, item checkout, etc ) 4) Run process_message_queue.pl, note the error 5) Apply the patch 4) Run process_message_queue.pl, no error this time! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |9021 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.