[Bug 27297] New: When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Bug ID: 27297 Summary: When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Two issues: 1 - We only add the required class, we don't make the input required 2 - We don't add a 'blank' option, so the field is preselected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114620&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114620|0 |1 is obsolete| | --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 114737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114737&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this doesn't work correctly. 1) When itemtype is set to mandatory, the None option appears multiple times in the pull down, I believe once for every item type listed. 2) when itemtype is not set to mandatory, the None option doesn't appear as all, which means as you can't unselect the itemtype it's still kidna mandatory. We need to fix 1) for sure,... but can we fix 2) please at the same time and always include a none option? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114737|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115020&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115020|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115215&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115215|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115219&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Nick, no complaints this time :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Just noting: Bug 18680 added "empty" for the same purpose at the staff side. This added "blank" for OPAC. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org