[Bug 24636] New: Acquisitions planning sections untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Bug ID: 24636 Summary: Acquisitions planning sections untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr When you go in Adminitration > Budgets > (Budget) > Planning > Plan by ... (aqplan.pl), the terms for MONTHS, BRANCHES and ITEMTYPES are not translatable. To reproduce: 1. Install another language if you don't already have one 2. Go to Administration > Budgets 3. Click on a budget (or create one if you don't already have one) 4. Click on Planning and choose one of the options (for example Plan by months) 5. Notice at the top it says 'Planning for <budget name> by MONTHS' 6. Switch languages 7. Notice 'MONTHS' is still in English I looked in my fr-CA-staff-prog.po file and 'MONTHS' is not in there (even after an update). I know it's been like this for several versions, but I can't find a bug report for this. Sorry if it is a duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103893&action=edit Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103893|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103952&action=edit Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll pass this, but wonder if it would be better to include the 'by' in the include. by months = nach Monaten months = Monate The translation changes at least in German because of declination. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103952|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104142&action=edit Bug 24636: translate planning sections This patch adds a new inc file to process and translate plannig sections To test: 1) Apply patch 2) Create new language files (cd misc/translator; ./translate create xx-YY) 3) Verify new file is taken into account in translation files egrep -n budget_planning misc/translator/xx-YY*.po check new strings in staff-prog file 4) Go to Administration > Budgets > Founds > Planning select different options, check page title and 'Planning for...' phrase 5) Translate strings, install new language, enable it, verify the text change with options like point 4) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #3)
I'll pass this, but wonder if it would be better to include the 'by' in the include.
by months = nach Monaten months = Monate
The translation changes at least in German because of declination.
No problem to write an alternative patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 104241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104241&action=edit Bug 24636: follow-up - move 'by' into include file To ease correct translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Katrin Fischer from comment #3)
I'll pass this, but wonder if it would be better to include the 'by' in the include.
by months = nach Monaten months = Monate
The translation changes at least in German because of declination.
Added follow-up, possible target of your super-powers :) or switch to NSO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104242&action=edit Bug 24636: (follow-up) - move 'by' into include file To ease correct translation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the follow-up! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22832 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22832 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24636 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org