[Bug 17840] New: Add classes to internal and public notes in checkouts table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Bug ID: 17840 Summary: Add classes to internal and public notes in checkouts table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In order to be able to style the internal and public notes so they stand out more, it would be good if each of them had their own class. At the moment, there seems something not quite right, as both have an empty class="". To test: 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #1 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59053&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there i -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59053|0 |1 is obsolete| | --- Comment #2 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59054&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59054|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 59152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59152&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emma.nakamura.smith@gmail.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a test just after, if true the "circ-hlt" class name will be used. I guess we want the 2 new classes in any cases. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Emma, you should also change the author's name of this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59152|0 |1 is obsolete| | --- Comment #6 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59284&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma <emma.nakamura.smith@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59284|0 |1 is obsolete| | --- Comment #7 from Emma <emma.nakamura.smith@gmail.com> --- Created attachment 59286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59286&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59286|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59503&action=edit [SIGNED-OFF] Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- But now the circ-hlt class name are removed. No idea if we must keep it or not. Any opinions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Chris, do you know if this circ-hlt class is still useful? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Nope, they can safely be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18155 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59503|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60619&action=edit Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Emma! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Severity|enhancement |trivial --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is marked enh, but as the classes being empty before can be considered a bug and the change is very small, I have decided to push this small one. This patch has been pushed to 16.11.x and will be in 16.11.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.11 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org