[Bug 40180] New: Missing Cypress tests for 'Holds to pull' library filters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Bug ID: 40180 Summary: Missing Cypress tests for 'Holds to pull' library filters Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 40118 is going to be pushed without tests to cover the changes. We should remedy to that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com Depends on| |40118 Version|24.11 |unspecified Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40118 [Bug 40118] Regression - 'Holds to pull' library filters don't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40174 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40174 [Bug 40174] Add a way to cleanly insert data in DB from Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183375&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183376&action=edit Bug 40180: Add tests for insertSampleHold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- In case of conflict, the tree is available at https://gitlab.com/joubu/Koha/-/commits/bug_40180 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40181 [Bug 40181] Cypress tests - Ensure that insertData does not leave data in the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183375|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183930&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183376|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183931&action=edit Bug 40180: Add tests for insertSampleHold -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183932&action=edit Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183930|0 |1 is obsolete| | Attachment #183931|0 |1 is obsolete| | Attachment #183932|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183933&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183934&action=edit Bug 40180: Add tests for insertSampleHold -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183935&action=edit Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects -- You are receiving this mail because: You are watching all task changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183933|0 |1 is obsolete| | Attachment #183934|0 |1 is obsolete| | Attachment #183935|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184221&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184222&action=edit Bug 40180: Add tests for insertSampleHold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184223&action=edit Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184221|0 |1 is obsolete| | Attachment #184222|0 |1 is obsolete| | Attachment #184223|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184227&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184228&action=edit Bug 40180: Add tests for insertSampleHold Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184229&action=edit Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184227|0 |1 is obsolete| | Attachment #184228|0 |1 is obsolete| | Attachment #184229|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184334&action=edit Bug 40180: (bug 40118 follow-up) Add Cypress tests This patch heavily reuses what has been introduced by the previous patches in the tree, and add a insertSampleHold task to be reusable easily in other tests. Test plan: All Cypress tests must pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184335&action=edit Bug 40180: Add tests for insertSampleHold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184336&action=edit Bug 40180: Improve deleteSampleObjects We want the task to accept an Object or an Array of Objects Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184532&action=edit Bug 40180: Fix Cypress test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #20)
Created attachment 184532 [details] [review] Bug 40180: Fix Cypress test
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependancies not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 Bug 40180 depends on bug 40174, which changed state. Bug 40174 Summary: Add a way to cleanly insert data in DB from Cypress tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40174 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40180 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |david@davidnind.com --- Comment #24 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org