[Bug 38192] New: DT - State not restored correctly on suggestion tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Bug ID: 38192 Summary: DT - State not restored correctly on suggestion tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 33426 There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38183 [Bug 38183] Cant set suggestion manager when there are multiple tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172862&action=edit Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172862|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172868&action=edit Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172868|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172879&action=edit Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Remember user's table state for all tables (Generalise table saveState for all tables) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172879|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173352&action=edit Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DT - State not restored |State not restored |correctly on suggestion |correctly on suggestion |tables |tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply clean to 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Bug 38192 depends on bug 38183, which changed state. Bug 38183 Summary: Can't set suggestion manager when there are multiple tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38183 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38192 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41857 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org